Skip to content

Fix hanging 'console-eager-eval' reference after #164 #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

Fix hanging 'console-eager-eval' reference after #164 #167

merged 1 commit into from
May 23, 2025

Conversation

huntie
Copy link
Member

@huntie huntie commented May 23, 2025

Summary

Quick follow up to #164. This change is already present in the 0.78, 0.79 pick versions.

Test plan

✅ End to end tested, no console error.

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@huntie huntie requested a review from vzaidman May 23, 2025 15:36
@huntie huntie merged commit 343405b into facebook:main May 23, 2025
1 of 2 checks passed
@huntie huntie deleted the fix-missing-setting branch May 23, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzaidman vzaidman vzaidman approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huntie @vzaidman @facebook-github-bot