Skip to content

[0.78] Update debugger-frontend from 7727db85...911a4d98 (S523384 mitigation) #51571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 0.78-stable
Choose a base branch
from

Conversation

huntie
Copy link
Member

@huntie huntie commented May 23, 2025

Summary

This is a cherry pick of facebook/react-native-devtools-frontend#164, built from the corresponding 0.78-stable branch of https://github.com/facebook/react-native-devtools-frontend.

Command run:

node scripts/debugger-frontend/sync-and-build.js --branch 0.78-stable

Context

This is a mitigation for S523384, affecting builds of react-native-devtools-frontend shipped React Native 0.78 and onwards.

Specifically, it disables all eager evaluation features from the Console panel, which, following an upstream ChromeDevTools sync, puts the frontend ahead of what Hermes currently supports under CDP.

  • Functionally, this can cause erratic and unsafe console behaviour, that executes side effects, while typing.

image

Changelog:
[General][Fixed] - React Native DevTools: Eager evaluation and Live Expressions in the Console tab have been temporarily disabled, as they were being incorrectly executed with side effects

Test Plan

See facebook/react-native-devtools-frontend#164.

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants