[0.80] Update debugger-frontend from bc635fa...343405b (S523384 mitigation) #51564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
huntie
force-pushed
the
0.80-S523384-mitigation
branch
from
20a7751 to
25a8338
Compare
huntie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a cherry pick of facebook/react-native-devtools-frontend#164, built from the corresponding
0.80-stablebranch of https://github.com/facebook/react-native-devtools-frontend.Command run:
Context
This is a mitigation for S523384, affecting builds of
react-native-devtools-frontendshipped React Native 0.78 and onwards.Specifically, it disables all eager evaluation features from the Console panel, which, following an upstream ChromeDevTools sync, puts the frontend ahead of what Hermes currently supports under CDP.
Changelog:
[General][Fixed] - React Native DevTools: Eager evaluation and Live Expressions in the Console tab have been temporarily disabled, as they were being incorrectly executed with side effects
Test Plan
See facebook/react-native-devtools-frontend#164.