Issue 445 LINT fixes #461
Closed
Issue 445 LINT fixes #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,7 +116,7 @@ import el2_pkg::*; | |||
| ); | |||
|
|
|||
| assign start_addr_dccm_or_pic = start_addr_in_dccm_region_d | start_addr_in_pic_region_d; | |||
| assign base_reg_dccm_or_pic = ((rs1_region_d[3:0] == pt.DCCM_REGION) & pt.DCCM_ENABLE) | (rs1_region_d[3:0] == pt.PIC_REGION); | |||
| assign base_reg_dccm_or_pic = (|((rs1_region_d[3:0] == pt.DCCM_REGION) & pt.DCCM_ENABLE)) | (rs1_region_d[3:0] == pt.PIC_REGION); | |||
There was a problem hiding this comment.
Since we're changing this line anyway, wouldn't it be more conceptually accurate/stylistically preferred to use logical boolean operators instead of bitwise:
assign base_reg_dccm_or_pic = ((rs1_region_d[3:0] == pt.DCCM_REGION) && pt.DCCM_ENABLE) || (rs1_region_d[3:0] == pt.PIC_REGION);
Merged
|
Let's abandon this PR, as the changes have been pulled into #483 |
39 tasks
|
#483 is completed, including the changes from this PR. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various LINT issues addressed. All changes are passing RTL->RTL formal equivalence.