Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SHA256 lint fixes #466

Merged
merged 10 commits into from
Mar 19, 2024
Merged

SHA256 lint fixes #466

merged 10 commits into from
Mar 19, 2024

Conversation

upadhyayulakiran
Copy link
Contributor

  1. Remove wntz_1st_blk since it's not used
  2. Resize wntz_fsm to 2 bits wide
  3. Trig command_done notif intr for every wntz iteration or regular sha256 operation. Currently command_done is triggered for every sha operation of wntz which is unnecessary

@mojtaba-bisheh mojtaba-bisheh self-requested a review March 14, 2024 19:51
mojtaba-bisheh
mojtaba-bisheh previously approved these changes Mar 14, 2024
View reviewed changes
mojtaba-bisheh
mojtaba-bisheh previously approved these changes Mar 14, 2024
View reviewed changes
@mojtaba-bisheh mojtaba-bisheh linked an issue Mar 14, 2024 that may be closed by this pull request
[LMS] cmd_done toggles with each winternitz round #464
Closed
calebofearth
calebofearth previously approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@calebofearth calebofearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if Mike has any other thoughts before we merge.

Nitsirks
Nitsirks previously approved these changes Mar 14, 2024
View reviewed changes
Nitsirks
Nitsirks previously approved these changes Mar 15, 2024
View reviewed changes
mojtaba-bisheh
mojtaba-bisheh previously approved these changes Mar 15, 2024
View reviewed changes
@calebofearth calebofearth merged commit 612ea2e into main Mar 19, 2024
49 checks passed
@calebofearth calebofearth deleted the user/dev/kupadhyayula/sha256_lint_fixes branch March 19, 2024 17:10
@ludwigatlubis
Copy link
Contributor

@mojtaba-bisheh
We re-ran the assertions and all warnings & failings assertions are gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mojtaba-bisheh mojtaba-bisheh mojtaba-bisheh approved these changes

@calebofearth calebofearth calebofearth approved these changes

@Nitsirks Nitsirks Nitsirks left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LMS] cmd_done toggles with each winternitz round
5 participants
@upadhyayulakiran @ludwigatlubis @calebofearth @mojtaba-bisheh @Nitsirks