Messages RFC #85
Merged
Messages RFC #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upbqdn
reviewed
May 3, 2021
teor2345
suggested changes
May 3, 2021
There was a problem hiding this comment.
@oxarbitrage here is my initial review of the FROST serialization RFC.
It looks good so far, but it needs more information about message validation, and the contents of each specific message type.
|
In my suggestions, I assumed there will never be more than 256 versions or message types. |
teor2345
reviewed
May 5, 2021
teor2345
reviewed
May 5, 2021
teor2345
reviewed
May 5, 2021
teor2345
reviewed
May 5, 2021
teor2345
reviewed
May 5, 2021
teor2345
reviewed
May 5, 2021
teor2345
reviewed
May 5, 2021
oxarbitrage
commented
May 6, 2021
oxarbitrage
commented
May 21, 2021
Closed
oxarbitrage
commented
May 29, 2021
teor2345
reviewed
May 31, 2021
teor2345
reviewed
May 31, 2021
teor2345
reviewed
May 31, 2021
teor2345
reviewed
May 31, 2021
teor2345
suggested changes
May 31, 2021
teor2345
reviewed
May 31, 2021
teor2345
reviewed
May 31, 2021
Co-authored-by: teor <[email protected]>
Co-authored-by: teor <[email protected]>
dconnolly
approved these changes
May 31, 2021
teor2345
reviewed
Jun 1, 2021
teor2345
reviewed
Jun 1, 2021
teor2345
reviewed
Jun 1, 2021
Co-authored-by: teor <[email protected]>
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A draft proposal to build exchangeable messages in FROST. Looking for collaboration.
I started a document in the form of an RFC because i want to have feedback. This does not need to be merged but i will like to use the github for collaboration.