Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change MsgVersion to enum #112

Open
oxarbitrage opened this issue May 31, 2021 · 0 comments
Open

Change MsgVersion to enum #112

oxarbitrage opened this issue May 31, 2021 · 0 comments
Assignees
@dconnolly @chelseakomlo
Labels
frost

Comments

@oxarbitrage
Copy link
Contributor

In #85 we added a MsgVersion struct that can be any u8 number. We might want to change this to an enum to be strict: https://github.com/ZcashFoundation/redjubjub/pull/85/files#r636471258

As commented in https://github.com/ZcashFoundation/redjubjub/pull/85/files#r642162509 the wire format will not change so it is not an urgent change, for this reason we isolated in this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dconnolly dconnolly

@chelseakomlo chelseakomlo

Labels
frost
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dconnolly @chelseakomlo @oxarbitrage @ftm1000