Frost messages #83
Closed
Frost messages #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelseakomlo
requested changes
Apr 29, 2021
| <h3 id="org3b224f7"><span class="section-number-3">3.1</span> Key Generation with DKG</h3> | ||
| <div class="outline-text-3" id="text-3-1"> | ||
| <p> | ||
| These messages are sent during the Distributed Key Generation (DKG). |
There was a problem hiding this comment.
I wouldn't include this in this commit as the DKG hasn't yet been implemented.
| @@ -99,6 +177,8 @@ pub struct GroupCommitment(jubjub::ExtendedPoint); | |||
| /// | |||
| /// To derive a FROST keypair, the receiver of the [`SharePackage`] *must* call | |||
| /// .into(), which under the hood also performs validation. | |||
| #[derive(PartialEq)] | |||
| #[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))] | |||
There was a problem hiding this comment.
I would think about whether having an 'external' data type and an 'internal' data type will make maintaining this implementation easier in the future. I believe this is what Zebra does- @dconnolly @teor2345 can give good guidance on this.
There was a problem hiding this comment.
Zebra has three layers of types in its messages:
- external message protocol based on Bitcoin
zebra_network::protocol::external - internal translation of those messages into a request-response protocol
zebra_network::protocol::internal - Zcash types based on the chain spec
zebra_chain
The external and internal messages are wrappers for the chain types.
Since FROST isn't inheriting a badly-specified legacy network protocol, you could have a much simpler design:
- message header struct
- message types enum containing internal types
And then the serialization layer can deal with:
- applying and removing headers
- any logic around version compatibility
struct Header {
version: u16
..
}
enum Message {
Share {
package: SharePackage
}
Sign {
..
}
..
}
|
Replaced by #85 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, only the
SharePackagestruct is ready to be serialized by Serde. This is the main struct used in the key generation with trusted dealer.