Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messages RFC #85

Merged
merged 70 commits into from
Jun 15, 2021
Merged

Messages RFC #85

merged 70 commits into from
Jun 15, 2021

Commits on May 2, 2021

  1. add a messages rfc

    @oxarbitrage
    oxarbitrage committed May 2, 2021
    Configuration menu
    Copy the full SHA
    5a86e0c View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. update MsgDealerBroadcast

    @oxarbitrage
    oxarbitrage committed May 4, 2021
    Configuration menu
    Copy the full SHA
    c8eda81 View commit details
    Browse the repository at this point in the history

  2. remove msg type numbers, fix version msg

    @oxarbitrage
    oxarbitrage committed May 4, 2021
    Configuration menu
    Copy the full SHA
    d0a569c View commit details
    Browse the repository at this point in the history

  3. update MsgCommitments

    @oxarbitrage
    oxarbitrage committed May 4, 2021
    Configuration menu
    Copy the full SHA
    0e4a911 View commit details
    Browse the repository at this point in the history

  4. update MsgSigningPackage and MsgSignatureShare

    @oxarbitrage
    oxarbitrage committed May 4, 2021
    Configuration menu
    Copy the full SHA
    994a67a View commit details
    Browse the repository at this point in the history

  5. remove non needed fields from MsgDealerBroadcast

    @oxarbitrage
    oxarbitrage committed May 4, 2021
    Configuration menu
    Copy the full SHA
    e4ecef9 View commit details
    Browse the repository at this point in the history

  6. update validate section

    @oxarbitrage
    oxarbitrage committed May 4, 2021
    Configuration menu
    Copy the full SHA
    4cf6b87 View commit details
    Browse the repository at this point in the history

  7. include the receiver side in validation section

    @oxarbitrage
    oxarbitrage committed May 4, 2021
    Configuration menu
    Copy the full SHA
    4b88806 View commit details
    Browse the repository at this point in the history

  8. start a Serialized Size section

    @oxarbitrage
    oxarbitrage committed May 4, 2021
    Configuration menu
    Copy the full SHA
    3d54c96 View commit details
    Browse the repository at this point in the history

  9. complete the rest of the messages sizes

    @oxarbitrage
    oxarbitrage committed May 4, 2021
    Configuration menu
    Copy the full SHA
    f74f57c View commit details
    Browse the repository at this point in the history

Commits on May 5, 2021

  1. join serialization sections, readd group_public to initial msg

    @oxarbitrage
    oxarbitrage committed May 5, 2021
    Configuration menu
    Copy the full SHA
    b725e22 View commit details
    Browse the repository at this point in the history

  2. add frost:: to frost types, update intro, others

    @oxarbitrage
    oxarbitrage committed May 5, 2021
    Configuration menu
    Copy the full SHA
    b80a5a6 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. change better name for alias

    @oxarbitrage
    oxarbitrage committed May 6, 2021
    Configuration menu
    Copy the full SHA
    dd0b7de View commit details
    Browse the repository at this point in the history

  2. unpack SigningPackage in MsgSigningPackage

    @oxarbitrage
    oxarbitrage committed May 6, 2021
    Configuration menu
    Copy the full SHA
    d0c8f18 View commit details
    Browse the repository at this point in the history

  3. unpack commitments in MsgDealerBroadcast

    @oxarbitrage
    oxarbitrage committed May 6, 2021
    Configuration menu
    Copy the full SHA
    b3902e5 View commit details
    Browse the repository at this point in the history

  4. use affinepoint everywhere

    @oxarbitrage
    oxarbitrage committed May 6, 2021
    Configuration menu
    Copy the full SHA
    647d199 View commit details
    Browse the repository at this point in the history

  5. unpack VerificationKey

    @oxarbitrage
    oxarbitrage committed May 6, 2021
    Configuration menu
    Copy the full SHA
    7394400 View commit details
    Browse the repository at this point in the history

  6. unpack Signature in MsgFinalSignature

    @oxarbitrage
    oxarbitrage committed May 6, 2021
    Configuration menu
    Copy the full SHA
    c587e84 View commit details
    Browse the repository at this point in the history

  7. update validation section

    @oxarbitrage
    oxarbitrage committed May 6, 2021
    Configuration menu
    Copy the full SHA
    f98c5ce View commit details
    Browse the repository at this point in the history

  8. byte order note

    @oxarbitrage
    oxarbitrage committed May 6, 2021
    Configuration menu
    Copy the full SHA
    1ee8059 View commit details
    Browse the repository at this point in the history

  9. add size fields in MsgSigningPackage

    @oxarbitrage
    oxarbitrage committed May 6, 2021
    Configuration menu
    Copy the full SHA
    61740e2 View commit details
    Browse the repository at this point in the history

  10. fix closing vector

    @oxarbitrage
    oxarbitrage committed May 6, 2021
    Configuration menu
    Copy the full SHA
    b608732 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2021

  1. replace tuples with new types

    @oxarbitrage
    oxarbitrage committed May 8, 2021
    Configuration menu
    Copy the full SHA
    dc90235 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2021

  1. add Other considerations section

    @oxarbitrage
    oxarbitrage committed May 9, 2021
    Configuration menu
    Copy the full SHA
    104d0f5 View commit details
    Browse the repository at this point in the history

  2. change other considerations section to not included

    @oxarbitrage
    oxarbitrage committed May 9, 2021
    Configuration menu
    Copy the full SHA
    debcbc1 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. fix typos

    @oxarbitrage
    oxarbitrage committed May 10, 2021
    Configuration menu
    Copy the full SHA
    0ea8af9 View commit details
    Browse the repository at this point in the history

  2. use to_bytes in primitive types and reduce serialization size

    @oxarbitrage
    oxarbitrage committed May 10, 2021
    Configuration menu
    Copy the full SHA
    42763c1 View commit details
    Browse the repository at this point in the history

  3. add note about large messages

    @oxarbitrage
    oxarbitrage committed May 10, 2021
    Configuration menu
    Copy the full SHA
    81ceee0 View commit details
    Browse the repository at this point in the history

  4. change comments to doc comments

    @oxarbitrage
    oxarbitrage committed May 10, 2021
    Configuration menu
    Copy the full SHA
    987cddd View commit details
    Browse the repository at this point in the history

  5. remove lenght of msg to be signed from rust

    @oxarbitrage
    oxarbitrage committed May 10, 2021
    Configuration menu
    Copy the full SHA
    b82e414 View commit details
    Browse the repository at this point in the history

  6. replace CollectedCommitment with a HashMap

    @oxarbitrage
    oxarbitrage committed May 10, 2021
    Configuration menu
    Copy the full SHA
    28aefe2 View commit details
    Browse the repository at this point in the history

  7. remove participants field from rust in MsgSigningPackage

    @oxarbitrage
    oxarbitrage committed May 10, 2021
    Configuration menu
    Copy the full SHA
    c90f1e3 View commit details
    Browse the repository at this point in the history

  8. fix typo

    @oxarbitrage
    oxarbitrage committed May 10, 2021
    Configuration menu
    Copy the full SHA
    2293e1a View commit details
    Browse the repository at this point in the history

  9. change Participant to ParticipantID

    @oxarbitrage
    oxarbitrage committed May 10, 2021
    Configuration menu
    Copy the full SHA
    e14631b View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. update payloads rust code

    @oxarbitrage
    oxarbitrage committed May 11, 2021
    Configuration menu
    Copy the full SHA
    4284ddb View commit details
    Browse the repository at this point in the history

  2. add a new not included item

    @oxarbitrage
    oxarbitrage committed May 11, 2021
    Configuration menu
    Copy the full SHA
    300e503 View commit details
    Browse the repository at this point in the history

  3. add line to AffinePoint description

    @oxarbitrage
    oxarbitrage committed May 11, 2021
    Configuration menu
    Copy the full SHA
    b8abdf5 View commit details
    Browse the repository at this point in the history

  4. update serialization

    @oxarbitrage
    oxarbitrage committed May 11, 2021
    Configuration menu
    Copy the full SHA
    cf84c6f View commit details
    Browse the repository at this point in the history

  5. add a new validation rules section

    @oxarbitrage
    oxarbitrage committed May 11, 2021
    Configuration menu
    Copy the full SHA
    0d51a74 View commit details
    Browse the repository at this point in the history

  6. split rules in header and payload sub sections

    @oxarbitrage
    oxarbitrage committed May 11, 2021
    Configuration menu
    Copy the full SHA
    632ed96 View commit details
    Browse the repository at this point in the history

  7. fix missing field name and type in MsgCommitments serialization

    @oxarbitrage
    oxarbitrage committed May 11, 2021
    Configuration menu
    Copy the full SHA
    43a302b View commit details
    Browse the repository at this point in the history

  8. use some escape characters

    @oxarbitrage
    oxarbitrage committed May 11, 2021
    Configuration menu
    Copy the full SHA
    2d6290e View commit details
    Browse the repository at this point in the history

  9. add definitions

    @oxarbitrage
    oxarbitrage committed May 11, 2021
    Configuration menu
    Copy the full SHA
    899ea9e View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Fix a typo

    @teor2345
    teor2345 authored May 12, 2021
    Configuration menu
    Copy the full SHA
    70eb9aa View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Name, Doc and Serialization Tweaks, and a Test Plan

    @teor2345
    teor2345 authored May 13, 2021
    Configuration menu
    Copy the full SHA
    a3d01a5 View commit details
    Browse the repository at this point in the history

  2. Remove the separate MsgCommitments type

    @teor2345
    teor2345 authored May 13, 2021
    Configuration menu
    Copy the full SHA
    a53b40c View commit details
    Browse the repository at this point in the history

  3. Fix a missed type

    @teor2345
    teor2345 authored May 13, 2021
    Configuration menu
    Copy the full SHA
    8955be9 View commit details
    Browse the repository at this point in the history

  4. Add a constant for this serialization version

    @teor2345
    teor2345 authored May 13, 2021
    Configuration menu
    Copy the full SHA
    284d465 View commit details
    Browse the repository at this point in the history

  5. Reserve specific participant IDs for the dealer and aggregator 

    Also explicitly identify the sender and receiver for each message.
    @teor2345
    teor2345 authored May 13, 2021
    Configuration menu
    Copy the full SHA
    86f5773 View commit details
    Browse the repository at this point in the history

  6. Clarify participant ID changes

    @teor2345
    teor2345 authored May 13, 2021
    Configuration menu
    Copy the full SHA
    79eda4e View commit details
    Browse the repository at this point in the history

  7. fix missing msg names

    @oxarbitrage
    oxarbitrage committed May 13, 2021
    Configuration menu
    Copy the full SHA
    9db4453 View commit details
    Browse the repository at this point in the history

  8. split doc comment in lines

    @oxarbitrage
    oxarbitrage committed May 13, 2021
    Configuration menu
    Copy the full SHA
    ed337b6 View commit details
    Browse the repository at this point in the history

  9. remove some spaces after newlines

    @oxarbitrage
    oxarbitrage committed May 13, 2021
    Configuration menu
    Copy the full SHA
    5f3184e View commit details
    Browse the repository at this point in the history

  10. fix definitions after changes to ParticipantID

    @oxarbitrage
    oxarbitrage committed May 13, 2021
    Configuration menu
    Copy the full SHA
    e892d30 View commit details
    Browse the repository at this point in the history

  11. replace ParticipantID with ParticipantId everywhere remaining

    @oxarbitrage
    oxarbitrage committed May 13, 2021
    Configuration menu
    Copy the full SHA
    111eab2 View commit details
    Browse the repository at this point in the history

  12. Make state-based validation out of scope

    @teor2345
    teor2345 authored May 13, 2021
    Configuration menu
    Copy the full SHA
    a1b9266 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. remove msg_type validation rule

    @oxarbitrage
    oxarbitrage committed May 14, 2021
    Configuration menu
    Copy the full SHA
    c92b892 View commit details
    Browse the repository at this point in the history

  2. change some validation rules

    @oxarbitrage
    oxarbitrage committed May 14, 2021
    Configuration menu
    Copy the full SHA
    21c309f View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. forbid multi-bytes in serialization 

    Co-authored-by: teor <[email protected]>
    @oxarbitrage @teor2345
    oxarbitrage and teor2345 authored May 17, 2021
    Configuration menu
    Copy the full SHA
    29904a4 View commit details
    Browse the repository at this point in the history

  2. change group_public

    @oxarbitrage
    oxarbitrage committed May 17, 2021
    Configuration menu
    Copy the full SHA
    1f5f04f View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. put variable-length fields last in messages 

    Co-authored-by: teor <[email protected]>
    @oxarbitrage @teor2345
    oxarbitrage and teor2345 authored May 19, 2021
    Configuration menu
    Copy the full SHA
    3c8494d View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. text updates 

    Co-authored-by: Deirdre Connolly <[email protected]>
    @oxarbitrage @dconnolly
    oxarbitrage and dconnolly authored May 20, 2021
    Configuration menu
    Copy the full SHA
    74df415 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. change ParticipantId to u64

    @oxarbitrage
    oxarbitrage committed May 21, 2021
    Configuration menu
    Copy the full SHA
    9b057f2 View commit details
    Browse the repository at this point in the history

  2. change some primitives to frost types

    @oxarbitrage
    oxarbitrage committed May 21, 2021
    Configuration menu
    Copy the full SHA
    83794c5 View commit details
    Browse the repository at this point in the history

  3. update a field description

    @oxarbitrage
    oxarbitrage committed May 21, 2021
    Configuration menu
    Copy the full SHA
    f9e73af View commit details
    Browse the repository at this point in the history

Commits on May 22, 2021

  1. use FrostSignature instead of Scalar primitive

    @oxarbitrage
    oxarbitrage committed May 22, 2021
    Configuration menu
    Copy the full SHA
    189efc2 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. change type to SignatureResponse

    @oxarbitrage
    oxarbitrage committed May 26, 2021
    Configuration menu
    Copy the full SHA
    fa886e3 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2021

  1. use BTreeMap, update sizes, etc 

    Co-authored-by: teor <[email protected]>
    @oxarbitrage @teor2345
    oxarbitrage and teor2345 authored May 31, 2021
    Configuration menu
    Copy the full SHA
    c4cb055 View commit details
    Browse the repository at this point in the history

  2. Convert share_commitment to a BTreeMap 

    Co-authored-by: teor <[email protected]>
    @oxarbitrage @teor2345
    oxarbitrage and teor2345 authored May 31, 2021
    Configuration menu
    Copy the full SHA
    de1f625 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. add missing checks 

    Co-authored-by: teor <[email protected]>
    @oxarbitrage @teor2345
    oxarbitrage and teor2345 authored Jun 1, 2021
    Configuration menu
    Copy the full SHA
    fa74969 View commit details
    Browse the repository at this point in the history