AMReX/pyAMReX/PICSAR: Weekly Update #5126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
the
component: third party
ax3l
force-pushed
the
topic-amrexWeekly
branch
from
c20445f
to
fb59021
Compare
|
@WeiqunZhang there seem to be new issues in this PR from the AMReX update (UB san as well as a series of tests see issues). |
This comment was marked as resolved.
This comment was marked as resolved.
ax3l
force-pushed
the
topic-amrexWeekly
branch
2 times, most recently
from
111fe99
to
14b605c
Compare
|
@WeiqunZhang something changed in the way in WarpX, which we abort on. |
|
Yes, we changed the default max grid size to 64 from 32.
…On Wed, Aug 14, 2024, 11:12 PM Axel Huebl ***@***.***> wrote:
@WeiqunZhang <https://github.com/WeiqunZhang> something changed in the
way ThetaImplicitPicard_1d is run, which triggers a warning
!!! WARNING : [high][Performance] Too many resources / too little work!
It looks like you requested more compute resources than there are
total number of boxes of cells available (1). You started with (2)
MPI ranks, so (1) rank(s) will have no work.
Consider decreasing the amr.blocking_factor and amr.max_grid_size
parameters and/or using fewer MPI ranks.
More information:
https://warpx.readthedocs.io/en/latest/usage/workflows/parallelization.html
in WarpX, which we abort on.
—
Reply to this email directly, view it on GitHub
<#5126 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB37TYK2NOLOZJFADPPCHV3ZRRBGDAVCNFSM6AAAAABMKLHOS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJQG4ZTQNBVGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
ax3l
force-pushed
the
topic-amrexWeekly
branch
from
d8056cd
to
d4fabf6
Compare
|
@WeiqunZhang It looks like this PR AMReX-Codes/amrex#4083 fails some tests in WarpX. Failing EB tests (compiled and used at RT):
Failing EB tests in RZ (compiled and used at RT):
|
ax3l
commented
Aug 15, 2024
ax3l
commented
Aug 15, 2024
ax3l
force-pushed
the
topic-amrexWeekly
branch
from
f7fb6e1
to
419f4a6
Compare
Binning functions are refactored from `unsigned int` to `int` in AMReX-Codes/amrex#3684 for performance reasons. This updates our usage to reflect the changes.
Address a breaking change in AMReX.
AMReX default change: `amr.max_grid_size` is 64 from 32 now. Since these tests are run with 2 MPI ranks, ensure we have at least one box per MPI rank. Instead of 20=40/2 set again to 32, to keep checksums the same.
ax3l
force-pushed
the
topic-amrexWeekly
branch
from
419f4a6
to
0cc72dc
Compare
|
@WeiqunZhang this should now be ready for approval & merge :) |
WeiqunZhang
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weekly update to latest AMReX.
Weekly update to latest pyAMReX.
Weekly update to latest PICSAR (no changes).
developmentAMReX-Codes/pyamrex#352intAMReX-Codes/amrex#3684ref_ratios.size()amr.max_grid_sizedefault from 32 to 64