Fix a bug in ParmParse::remove #4093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should have used prefixed name.
|
Thanks! Just to connect it well, this fixes #4087 ? |
ax3l
reviewed
Aug 19, 2024
| @@ -1854,7 +1854,7 @@ int | |||
| ParmParse::remove (const char* name) | |||
| { | |||
| auto const pname = prefixedName(name); | |||
There was a problem hiding this comment.
Interesting that this did not throw an unused variable warning. Should we double check CI covers this?
ax3l
approved these changes
Aug 19, 2024
|
Huh, why does the WarpX app build still fail? We merged ECP-WarpX/WarpX#5126 the other day. Update: aha, this checks out WarpX 24.08 not its development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should have used prefixed name.