MLEBNodeFDLaplacian: Make it work with AMREX_USE_EB but with no EB #4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow the use of the linear solver when AMReX is built with EB support at compile time but no EB is built at runtime.
4 tasks
|
Oopsi, I see some regressions with this PR in ECP-WarpX/WarpX#5126 (comment) affecting EB-compiled (and EB-runtime-used) tests that now fail to converge. |
ax3l
reviewed
Aug 16, 2024
| AMREX_D_TERM(Array4<Real const> const& ecx = edgecent[0]->const_array(mfi);, | ||
| Array4<Real const> const& ecy = edgecent[1]->const_array(mfi);, | ||
| Array4<Real const> const& ecz = edgecent[2]->const_array(mfi)); | ||
| auto const& levset = levset_mf.const_array(mfi); | ||
| auto const& levset = factory->getVolFrac().const_array(mfi); |
There was a problem hiding this comment.
This looks like a bug
Suggested change
| auto const& levset = factory->getVolFrac().const_array(mfi); | |
| auto const& levset = factory->getLevelSet().const_array(mfi); |
ax3l
added a commit
to ax3l/amrex
that referenced
this pull request
Aug 16, 2024
Fix copy-paste regression from AMReX-Codes#4083
WeiqunZhang
pushed a commit
that referenced
this pull request
Aug 16, 2024
## Summary Fix copy-paste regression from #4083 ## Additional background #4083 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow the use of the linear solver when AMReX is built with EB support at compile time but no EB is built at runtime.
X-Ref: ECP-WarpX/WarpX#4865