Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AMReX/pyAMReX/PICSAR: Weekly Update #5126

Merged
merged 5 commits into from
Aug 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cuda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ jobs:
which nvcc || echo "nvcc not in PATH!"

git clone https://github.com/AMReX-Codes/amrex.git ../amrex
cd ../amrex && git checkout --detach 24.08 && cd -
cd ../amrex && git checkout --detach d9919c92db09ed9e927f9e4c7fb2ddcc161ab5ed && cd -
make COMP=gcc QED=FALSE USE_MPI=TRUE USE_GPU=TRUE USE_OMP=FALSE USE_FFT=TRUE USE_CCACHE=TRUE -j 4

ccache -s
Expand Down
2 changes: 1 addition & 1 deletion Regression/WarpX-GPU-tests.ini
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ emailBody = Check https://ccse.lbl.gov/pub/GpuRegressionTesting/WarpX/ for more

[AMReX]
dir = /home/regtester/git/amrex/
branch = 24.08
branch = d9919c92db09ed9e927f9e4c7fb2ddcc161ab5ed

[source]
dir = /home/regtester/git/WarpX
Expand Down
6 changes: 3 additions & 3 deletions Regression/WarpX-tests.ini
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ emailBody = Check https://ccse.lbl.gov/pub/RegressionTesting/WarpX/ for more det

[AMReX]
dir = /home/regtester/AMReX_RegTesting/amrex/
branch = 24.08
branch = d9919c92db09ed9e927f9e4c7fb2ddcc161ab5ed

[source]
dir = /home/regtester/AMReX_RegTesting/warpx
Expand Down Expand Up @@ -3824,7 +3824,7 @@ analysisRoutine = Examples/Tests/point_of_contact_EB/analysis.py
[ThetaImplicitPicard_1d]
buildDir = .
inputFile = Examples/Tests/Implicit/inputs_1d
runtime_params = warpx.abort_on_warning_threshold=high
runtime_params = warpx.abort_on_warning_threshold=high amr.max_grid_size=32
dim = 1
addToCompileString =
cmakeSetupOpts = -DWarpX_DIMS=1
Expand Down Expand Up @@ -3868,7 +3868,7 @@ analysisRoutine = Examples/Tests/Implicit/analysis_vandb_jfnk_2d.py
[SemiImplicitPicard_1d]
buildDir = .
inputFile = Examples/Tests/Implicit/inputs_1d_semiimplicit
runtime_params = warpx.abort_on_warning_threshold=high
runtime_params = warpx.abort_on_warning_threshold=high amr.max_grid_size=32
dim = 1
addToCompileString =
cmakeSetupOpts = -DWarpX_DIMS=1
Expand Down
4 changes: 2 additions & 2 deletions Source/Parallelization/GuardCellManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ guardCellManager::Init (
// the fine grid by a number of cells equal to the ref_ratio in the moving
// window direction.
if (do_moving_window) {
WARPX_ALWAYS_ASSERT_WITH_MESSAGE(ref_ratios.size() <= 1,
WARPX_ALWAYS_ASSERT_WITH_MESSAGE(max_level <= 1,
"The number of grow cells for the moving window currently assumes 2 levels max.");
const auto nlevs = static_cast<int>(ref_ratios.size()+1);
const auto nlevs = static_cast<int>(max_level+1);
const int max_r = (nlevs > 1) ? ref_ratios[0][moving_window_dir] : 2;

ngx = std::max(ngx,max_r);
Expand Down
6 changes: 3 additions & 3 deletions Source/Particles/Resampling/VelocityCoincidenceThinning.H
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public:
void labelOnSphericalVelocityGrid (const amrex::ParticleReal ux[],
const amrex::ParticleReal uy[],
const amrex::ParticleReal uz[],
const unsigned int indices[],
const int indices[],
int bin_array[], int index_array[],
const int cell_start, const int cell_stop ) const
{
Expand Down Expand Up @@ -151,7 +151,7 @@ public:
void labelOnCartesianVelocityGrid (const amrex::ParticleReal ux[],
const amrex::ParticleReal uy[],
const amrex::ParticleReal uz[],
const unsigned int indices[],
const int indices[],
int bin_array[], int index_array[],
const int cell_start, const int cell_stop ) const
{
Expand All @@ -168,7 +168,7 @@ public:

AMREX_GPU_HOST_DEVICE AMREX_FORCE_INLINE
void operator() (const amrex::ParticleReal ux[], const amrex::ParticleReal uy[],
const amrex::ParticleReal uz[], const unsigned int indices[],
const amrex::ParticleReal uz[], const int indices[],
int bin_array[], int index_array[],
const int cell_start, const int cell_stop) const
{
Expand Down
2 changes: 1 addition & 1 deletion cmake/dependencies/AMReX.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ set(WarpX_amrex_src ""
set(WarpX_amrex_repo "https://github.com/AMReX-Codes/amrex.git"
CACHE STRING
"Repository URI to pull and build AMReX from if(WarpX_amrex_internal)")
set(WarpX_amrex_branch "24.08"
set(WarpX_amrex_branch "d9919c92db09ed9e927f9e4c7fb2ddcc161ab5ed"
CACHE STRING
"Repository branch for WarpX_amrex_repo if(WarpX_amrex_internal)")

Expand Down
2 changes: 1 addition & 1 deletion cmake/dependencies/pyAMReX.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ option(WarpX_pyamrex_internal "Download & build pyAMReX" ON)
set(WarpX_pyamrex_repo "https://github.com/AMReX-Codes/pyamrex.git"
CACHE STRING
"Repository URI to pull and build pyamrex from if(WarpX_pyamrex_internal)")
set(WarpX_pyamrex_branch "24.08"
set(WarpX_pyamrex_branch "abdf332e25bfeef2b4d613d7adbe93fb8cf3e2f7"
CACHE STRING
"Repository branch for WarpX_pyamrex_repo if(WarpX_pyamrex_internal)")

Expand Down
2 changes: 1 addition & 1 deletion run_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ python3 -m pip cache purge

# Clone AMReX and warpx-data
git clone https://github.com/AMReX-Codes/amrex.git
cd amrex && git checkout --detach 24.08 && cd -
cd amrex && git checkout --detach d9919c92db09ed9e927f9e4c7fb2ddcc161ab5ed && cd -
# warpx-data contains various required data sets
git clone --depth 1 https://github.com/ECP-WarpX/warpx-data.git
# openPMD-example-datasets contains various required data sets
Expand Down
Loading