-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a narrow dependency group for testing in CI #348
add a narrow dependency group for testing in CI #348
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 39 39
Lines 917 917
=======================================
Hits 855 855
Misses 62 62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there should still be a dev
group that includes things like deptry
, ipykernel
, and ipywidgets
(maybe a few others, but I'm not sure). Those packages are not required for building the docs, but are used in development.
I can separate what is currently
|
Can we have
|
I am afraid |
That's totally fine with me. I just want each use case to have the minimum required dependencies. |
Agree with @damonbayer |
Co-authored-by: Damon Bayer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sbidari! I would like to discuss #348 (comment) before merging.
…dencies-and-run-ci-testing-in-that-context
closes #337