Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a narrow dependency group for testing in CI #348

Conversation

sbidari
Copy link
Collaborator

@sbidari sbidari commented Jul 31, 2024

closes #337

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.23%. Comparing base (3780889) to head (e9390a0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage   93.23%   93.23%           
=======================================
  Files          39       39           
  Lines         917      917           
=======================================
  Hits          855      855           
  Misses         62       62           
Flag Coverage Δ
unittests 93.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbidari sbidari marked this pull request as ready for review July 31, 2024 16:38
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there should still be a dev group that includes things like deptry, ipykernel, and ipywidgets (maybe a few others, but I'm not sure). Those packages are not required for building the docs, but are used in development.

@sbidari
Copy link
Collaborator Author

sbidari commented Jul 31, 2024

I think there should still be a dev group that includes things like deptry, ipykernel, and ipywidgets (maybe a few others, but I'm not sure). Those packages are not required for building the docs, but are used in development.

ipykernel is also required for building the docs, not sure about ipywidgets

I can separate what is currently docs into dev and docs as below. We would also need to install dev dependency for the website build but maybe we only need dev for development

[tool.poetry.group.dev.dependencies]
ipykernel = "^6.29.3"
nbconvert = "^7.16.4"
ipywidgets = "^8.1.3"
deptry = "^0.17.0"

[tool.poetry.group.docs.dependencies]
pillow = "^10.3.0"
pyyaml = "^6.0.0"
nbclient = "^0.10.0"
nbformat = "^5.10.0"
numpydoc = "^1.7.0"
arviz = "^0.18.0"
sphinx = "^7.2.6"
sphinxcontrib-mermaid = "^0.9.2"
sphinx-autodoc-typehints = "^2.1.0"
sphinx-book-theme = "^1.1.2"

@damonbayer
Copy link
Collaborator

We would also need to install dev dependency for the website build but maybe we only need dev for development

Can we have

  • main lets you use the package
  • main + test lets you run tests
  • main + docs lets you build the website
  • everything else goes in dev

@sbidari
Copy link
Collaborator Author

sbidari commented Jul 31, 2024

I am afraid dev might end up having just deptry but will run some tests to confirm

@damonbayer
Copy link
Collaborator

I am afraid dev might end up having just deptry but will run some tests to confirm

That's totally fine with me. I just want each use case to have the minimum required dependencies.

@dylanhmorris
Copy link
Collaborator

Agree with @damonbayer

@sbidari sbidari requested a review from damonbayer July 31, 2024 20:51
pyproject.toml Outdated Show resolved Hide resolved
@damonbayer damonbayer self-requested a review July 31, 2024 22:39
Copy link
Collaborator

@damonbayer damonbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sbidari! I would like to discuss #348 (comment) before merging.

@damonbayer damonbayer merged commit d8e9f5d into main Aug 1, 2024
9 checks passed
@damonbayer damonbayer deleted the 337-define-a-narrow-test-set-of-poetry-dependencies-and-run-ci-testing-in-that-context branch August 1, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define a narrow test set of poetry dependencies and run CI testing in that context
4 participants