Add new board: AET-H743-Basic #28371
Open
+1,670
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@villivateur there is merge commit in your PR. We do not allow merge commits so you will need to remove that. We also only allow one commit per subsystem/directory, so you will have to split out the AP_Bootloaders, and bootloader files into two different commits with appropriate names. |
villivateur
force-pushed
the
AET-H743-Basic
branch
from
230b971
to
40ecf80
Compare
villivateur
force-pushed
the
AET-H743-Basic
branch
from
40ecf80
to
be5c68d
Compare
|
@rishabsingh3003 The problems are fixed, please review again, thank you. |
andyp1per
requested changes
Oct 31, 2024
Hwurzburg
requested changes
Oct 31, 2024
There was a problem hiding this comment.
Readme should provide this information and also images: https://github.com/ArduPilot/ardupilot/blob/master/libraries/AP_HAL_ChibiOS/hwdef/X-MAV-AP-H743v2/README.md
Commit names should have library prefix, ie Tools: add AET-H743-Basic bootloader, etc.
villivateur
force-pushed
the
AET-H743-Basic
branch
from
4ae3c25
to
25fd0b8
Compare
|
I've made some changes and added the README. Please check again. |
andyp1per
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new board from AeroEggTech.
AET-H743-Basic.
The details can be found in https://www.aeroeggtech.com/en/autopilot.html