AP_Mount: Conditionally define serial_instance to fix unused variable compile error
#27607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much! I've tagged PeterB on this because he most likely knows best |
mduclehcm
force-pushed
the
ducle/fix-unused-variable
branch
from
e6c7e1b
to
b6e614b
Compare
peterbarker
reviewed
Jul 23, 2024
peterbarker
approved these changes
Jul 23, 2024
|
Hi @mduclehcm, Any chance you could rebase this on master? We don't normally allow "merge" commits. Squashing all commits together would also be good |
…le compile error - Wrapped the definition of `serial_instance` with preprocessor directives to ensure it is only defined when necessary. - This resolves the compile error caused by the unused variable when no features requiring `serial_instance` are enabled.
peterbarker
force-pushed
the
ducle/fix-unused-variable
branch
from
6e15d19
to
e7ba805
Compare
|
I've corrected the commit list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change:
serial_instancewith preprocessor directives to ensure it is only defined when necessary.serial_instanceare enabled.