Initial Django 1.11 and 2.0 support #21
Conversation
The legacy path isn't useable in Django 2.0
As of Django 1.11. Previously, it pulled them off the widget, itself. Django 1.11's template-based widget rendering rewrote this code. For compatibility with Django pre-1.11, we pass the base_attrs as a kwarg, this will be treated as an extra attr named "base_attrs", in old Django.
The private method _get_val_from_obj was removed in 2.0
|
Hey @stefanor, big thanks for your work! Sorry for the (extremely) late response. I burned out a little and neglected Open Source for some time. Getting back to business at last :) I'll merge this PR soon and drop compatibility with Django<1.11. |
|
@zsiciarz Meep. Anything we can do to help merge this and make a new release? |
|
Hi @zsiciarz , I am helping to set up the website for SciPy for next summer and we would like to adopt wafer (which has a dependency on this repo), but we are concerned about starting with 1.11 since it will be EOL by the time the conference comes around. Could you merge this PR? Or is there anything you need help with in order to complete the merge? |
|
The CTPUG organisation has taken over maintaining django-markitup - https://github.com/CTPUG/django-markitup . We've released django-markitup 3.5.0 with support for Django 2.0, and will continue working on the other outstanding issues. |
Enough to pass tests. (tested on everything except Python 3.4).
There are some compatibility hacks (noted with comments) that can be rolled back, once older Django support is dropped.
Fixes: #22