Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Django 1.11 and 2.0 support #21

Closed
wants to merge 6 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,23 @@ addons:
packages:
- python3.5
- python3.5-dev
- python3.6
- python3.6-dev
env:
- TOXENV=py27-1.8
- TOXENV=py27-1.9
- TOXENV=py27-1.10
- TOXENV=py27-1.11
- TOXENV=py34-1.8
- TOXENV=py34-1.9
- TOXENV=py34-1.10
- TOXENV=py34-1.11
- TOXENV=py35-1.9
- TOXENV=py35-1.10
- TOXENV=py35-1.11
- TOXENV=py35-2.0
- TOXENV=py36-1.11
- TOXENV=py36-2.0
install:
- pip install tox
script:
Expand Down
1 change: 1 addition & 0 deletions AUTHORS.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,5 @@ Mikhael Korneev
Neil Muller
Roman Akinfold <[email protected]>
Sebastian Brandt
Stefano Rivera <[email protected]>
Zbigniew Siciarz <[email protected]>
2 changes: 1 addition & 1 deletion CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ CHANGES
master (unreleased)
-------------------

* none yet
* Add support for Django 1.11 and 2.0.

3.0.0 (2016.09.04)
------------------
Expand Down
2 changes: 1 addition & 1 deletion markitup/fields.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def pre_save(self, model_instance, add):
return value.raw

def value_to_string(self, obj):
value = self._get_val_from_obj(obj)
value = self.value_from_object(obj)
return value.raw

def to_python(self, value):
Expand Down
7 changes: 6 additions & 1 deletion markitup/templatetags/markitup_tags.py
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
from __future__ import unicode_literals

from django import template
from django.core.urlresolvers import reverse, NoReverseMatch
from markitup import settings
from markitup.util import absolute_url
from markitup.fields import render_func

try:
from django.urls import NoReverseMatch, reverse
except ImportError:
# pre-Django 1.10
from django.core.urlresolvers import NoReverseMatch, reverse

register = template.Library()


Expand Down
12 changes: 10 additions & 2 deletions markitup/widgets.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,17 @@
import posixpath
from django import forms
from django.contrib.admin.widgets import AdminTextareaWidget
from django.core.urlresolvers import NoReverseMatch, reverse
from django.template.loader import render_to_string
from django.utils.safestring import mark_safe
from markitup import settings
from markitup.util import absolute_url

try:
from django.urls import NoReverseMatch, reverse
except ImportError:
# pre-Django 1.10
from django.core.urlresolvers import NoReverseMatch, reverse


class MarkupInput(forms.Widget):
def render(self, name, value, attrs=None):
Expand Down Expand Up @@ -71,7 +76,10 @@ def _media(self):
def render(self, name, value, attrs=None):
html = super(MarkItUpWidget, self).render(name, value, attrs)

final_attrs = self.build_attrs(attrs)
# Passing base_attrs as a kwarg for compatibility with Django < 1.11
# (where it will be treated as an innocuous attr named base_attrs)
final_attrs = self.build_attrs(
base_attrs=self.attrs, extra_attrs=attrs)

try:
preview_url = reverse('markitup_preview')
Expand Down
12 changes: 9 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,16 +1,22 @@
[tox]
envlist=
py27-1.{8,9,10},
py34-1.{8,9,10},
py35-1.{9,10}
py27-1.{8,9,10,11},
py34-1.{8,9,10,11},
py34-2.0,
py35-1.{9,10,11},
py35-2.0,
py36-{1.11,2.0}

[testenv]
basepython =
py27: python2.7
py34: python3.4
py35: python3.5
py36: python3.6
commands=python setup.py test
deps =
1.8: Django>=1.8,<1.9
1.9: Django>=1.9,<1.10
1.10: Django>=1.10,<1.11
1.11: Django>=1.11,<2.0
2.0: Django>=2.0,<2.1