Towards Django 2.0 support #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So they can be imported in Django 2.0
drnlm
approved these changes
Dec 28, 2017
| @@ -23,7 +23,7 @@ class Migration(migrations.Migration): | |||
| ('status', models.CharField(default=b'P', max_length=1, choices=[(b'A', b'Accepted'), (b'R', b'Not Accepted'), (b'P', b'Under Consideration')])), | |||
| ('_abstract_rendered', models.TextField(editable=False, blank=True)), | |||
| ('authors', models.ManyToManyField(related_name='talks', to=settings.AUTH_USER_MODEL)), | |||
| ('corresponding_author', models.ForeignKey(related_name='contact_talks', to=settings.AUTH_USER_MODEL)), | |||
| ('corresponding_author', models.ForeignKey(related_name='contact_talks', to=settings.AUTH_USER_MODEL, on_delete=models.CASCADE)), | |||
There was a problem hiding this comment.
Any specific reason to not reformat this long line like the other changes?
There was a problem hiding this comment.
I think I meant to come back to that. The whole area is a lot messier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly adding
on_deleteto migrations. Also, follow through on some other deprecations.This seems to work, at least for basic functionality, haven't tried building a schedule.
drf-extensionsdoesn't support Django 2.0 yet, I tested with local hacks to it. I see the same things in master, so guess it should at least be importable in the next release (although possibly not working correctly, yet).django-markitupdoesn't support Django 2.0 yet, but I did some work on that, upstream: zsiciarz/django-markitup#21.