eskip: refactor parsing tests to check error message #2874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
force-pushed
the
eskip/refactor-parse-tests
branch
from
57e81cf
to
e9fc110
Compare
Check value of error message to simplify followup fixes. E.g. #1885 introduced last route id to the error message without tests but last route could be empty or should not be present at all for `ParsePredicates` and `ParseFilters`. Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
eskip/refactor-parse-tests
branch
from
e9fc110
to
0116f8e
Compare
| }, { | ||
| "error", | ||
| "trallala", | ||
| nil, | ||
| true, | ||
| // TODO: remove empty last route id and fix position |
There was a problem hiding this comment.
Position fix could be done by #2873
This was referenced Jan 18, 2024
| for _, ti := range []struct { | ||
| msg string | ||
| expression string | ||
| check *Route | ||
| err bool | ||
| check []*Route |
There was a problem hiding this comment.
minor: maybe expectedRoutes would be better naming?
There was a problem hiding this comment.
I did not rename struct fields to keep diff small. All three tests use different naming
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check value of error message to simplify followup fixes.
E.g. #1885 introduced last route id to the error message without tests but last route could be empty or should not be present at all for
ParsePredicatesandParseFilters.