eskip: do not add empty last route id to parse error #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
added
minor
AlexanderYastrebov
force-pushed
the
eskip/fix-last-route-id
branch
from
169f26c
to
c80ab50
Compare
Follow up on #1885 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
eskip/fix-last-route-id
branch
from
c80ab50
to
764218c
Compare
| $$.route.id = $1.token | ||
| } | ||
|
|
||
| routeid: | ||
| symbol { | ||
| symbol colon { | ||
| // match symbol and colon to get route id early even if route parsing fails later |
There was a problem hiding this comment.
Is there any performance improvement here?
There was a problem hiding this comment.
No, performance change is within measurement deviation
goos: linux
goarch: amd64
pkg: github.com/zalando/skipper/eskip
cpu: Intel(R) Core(TM) i5-8350U CPU @ 1.70GHz
│ HEAD~1 │ HEAD │
│ sec/op │ sec/op vs base │
ParsePredicates-8 8.189µ ± 4% 8.515µ ± 4% +3.98% (p=0.007 n=10)
Parse-8 253.3m ± 2% 256.8m ± 3% +1.38% (p=0.011 n=10)
geomean 1.440m 1.479m +2.67%
│ HEAD~1 │ HEAD │
│ B/op │ B/op vs base │
ParsePredicates-8 1.961Ki ± 0% 1.961Ki ± 0% ~ (p=1.000 n=10)
Parse-8 49.02Mi ± 0% 49.02Mi ± 0% ~ (p=0.566 n=10)
geomean 313.7Ki 313.7Ki -0.00%
│ HEAD~1 │ HEAD │
│ allocs/op │ allocs/op vs base │
ParsePredicates-8 32.00 ± 0% 32.00 ± 0% ~ (p=1.000 n=10) ¹
Parse-8 1.080M ± 0% 1.080M ± 0% ~ (p=0.700 n=10)
geomean 5.879k 5.879k +0.00%
¹ all samples are equal
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #1885