-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: get conversation members is causing a full table scan #1891
fix: get conversation members is causing a full table scan #1891
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1891 +/- ##
=============================================
- Coverage 54.58% 54.58% -0.01%
Complexity 1620 1620
=============================================
Files 1008 1008
Lines 37006 37006
Branches 3331 3331
=============================================
- Hits 20201 20199 -2
- Misses 15450 15451 +1
- Partials 1355 1356 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
e406648
to
ef2ce26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 Good catch ! Just leaving a comment here, so we don't forget to double-check in case of regression for calling in federated environments:
- Conversation with members of different backends.
- Conversation with users of same team.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
adding % before and after a search quarry will cause it to ignore any indexing and do a full table scan
Solutions
there is not reason anymore for the search by conversation id so revert it to a good old =
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.