Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get conversation members is causing a full table scan #1891

Merged
merged 2 commits into from
Jul 17, 2023
Merged

fix: get conversation members is causing a full table scan #1891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef2ce26
fix: get conversation members is causing a full table scan
MohamadJaara Jul 17, 2023
181bae7
Merge branch 'develop' into fix/get_conversation_from_db_causing_a_fu…
MohamadJaara Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions persistence/src/commonMain/db_user/com/wire/kalium/persistence/Members.sq
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ DELETE FROM Member WHERE conversation = ? AND user = ?;
deleteMembersFromConversation:
DELETE FROM Member WHERE conversation = ?;

-- TODO: replace LIKE with absolute value
selectAllMembersByConversation:
SELECT * FROM Member WHERE conversation LIKE ('%' || :searchQuery || '%');
SELECT * FROM Member WHERE conversation = :conversation;

selectConversationByMember:
SELECT * FROM Member
Expand Down
2 changes: 1 addition & 1 deletion persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/member/MemberDAO.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ internal class MemberDAOImpl internal constructor(
}

override suspend fun observeConversationMembers(qualifiedID: QualifiedIDEntity): Flow<List<MemberEntity>> {
return memberQueries.selectAllMembersByConversation(qualifiedID.value)
return memberQueries.selectAllMembersByConversation(qualifiedID)
.asFlow()
.flowOn(coroutineContext)
.mapToList()
Expand Down
Loading