fix: get conversation members is causing a full table scan (#1891)

wireapp · Jul 17, 2023 · 0979362 · 0979362
1 parent 26c567c
commit 0979362
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/persistence/src/commonMain/db_user/com/wire/kalium/persistence/Members.sq b/persistence/src/commonMain/db_user/com/wire/kalium/persistence/Members.sq
@@ -22,9 +22,8 @@ DELETE FROM Member WHERE conversation = ? AND user = ?;
 deleteMembersFromConversation:
 DELETE FROM Member WHERE conversation = ?;
 
--- TODO: replace LIKE with absolute value
 selectAllMembersByConversation:
-SELECT * FROM Member WHERE conversation LIKE ('%' || :searchQuery || '%');
+SELECT * FROM Member WHERE conversation = :conversation;
 
 selectConversationByMember:
 SELECT * FROM Member

diff --git a/persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/member/MemberDAO.kt b/persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/member/MemberDAO.kt
@@ -122,7 +122,7 @@ internal class MemberDAOImpl internal constructor(
     }
 
     override suspend fun observeConversationMembers(qualifiedID: QualifiedIDEntity): Flow<List<MemberEntity>> {
-        return memberQueries.selectAllMembersByConversation(qualifiedID.value)
+        return memberQueries.selectAllMembersByConversation(qualifiedID)
             .asFlow()
             .flowOn(coroutineContext)
             .mapToList()