Skip to content

New Wasmi bytecode (take 2) #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Sep 18, 2024
Merged

New Wasmi bytecode (take 2) #1152

merged 38 commits into from
Sep 18, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Aug 26, 2024

A new take of #1148.

Advantages

  • Resolve a ton of technical dept and duplicate code/logic.
  • Easily change the way Wasmi instructions are dispatched and thus also allow for tail call based dispatch.
  • Simplify integration of new features such as:
    • Display impl for Instruction
    • Profiling stats for Instruction during execution

Precursors

These precursor PRs simplify the final integration of the new wasmi_ir crate.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 12.38779% with 488 lines in your changes missing coverage. Please review.

Project coverage is 78.20%. Comparing base (339566c) to head (6b52b1a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/ir/src/immeditate.rs 0.00% 184 Missing ⚠️
crates/ir/src/primitive.rs 0.00% 105 Missing ⚠️
crates/ir/src/span.rs 30.18% 74 Missing ⚠️
crates/ir/src/sequence.rs 0.00% 51 Missing ⚠️
crates/ir/src/enum.rs 9.67% 28 Missing ⚠️
crates/ir/src/visit_regs.rs 0.00% 23 Missing ⚠️
crates/ir/src/index.rs 29.16% 17 Missing ⚠️
crates/ir/src/error.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
- Coverage   79.66%   78.20%   -1.47%     
==========================================
  Files         298      307       +9     
  Lines       25295    25852     +557     
==========================================
+ Hits        20151    20217      +66     
- Misses       5144     5635     +491     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop force-pushed the rf-wasmi-bytecode-v2 branch 2 times, most recently from 17c660c to 12e0d49 Compare August 27, 2024 16:54
@Robbepop Robbepop force-pushed the rf-wasmi-bytecode-v2 branch from 84d0e52 to d8615c2 Compare September 4, 2024 11:08
@Robbepop Robbepop force-pushed the rf-wasmi-bytecode-v2 branch from d8615c2 to ab16cf3 Compare September 5, 2024 09:33
@Robbepop Robbepop force-pushed the rf-wasmi-bytecode-v2 branch from a23c713 to 739e15e Compare September 5, 2024 10:02
@Robbepop Robbepop force-pushed the rf-wasmi-bytecode-v2 branch from 739e15e to 9815bec Compare September 5, 2024 11:52
@Robbepop Robbepop marked this pull request as ready for review September 18, 2024 09:35
@Robbepop
Copy link
Member Author

PR to integrate wasmi_ir into the wasmi crate is done and all tests pass locally so we are (finally) ready to merge this PR.

@Robbepop Robbepop merged commit a19f9ee into main Sep 18, 2024
14 of 18 checks passed
@Robbepop Robbepop deleted the rf-wasmi-bytecode-v2 branch September 18, 2024 09:36
@Robbepop Robbepop changed the title WIP: new Wasmi bytecode (take 2) New Wasmi bytecode (take 2) Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant