-
Notifications
You must be signed in to change notification settings - Fork 308
New Wasmi bytecode (take 2) #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1152 +/- ##
==========================================
- Coverage 79.66% 78.20% -1.47%
==========================================
Files 298 307 +9
Lines 25295 25852 +557
==========================================
+ Hits 20151 20217 +66
- Misses 5144 5635 +491 ☔ View full report in Codecov by Sentry. |
17c660c
to
12e0d49
Compare
84d0e52
to
d8615c2
Compare
d8615c2
to
ab16cf3
Compare
a23c713
to
739e15e
Compare
739e15e
to
9815bec
Compare
We need to re-order enum variant fields due to a bug in the Rust compiler. Read more here: rust-lang/rust#53657
This increases its alignment from 2 to 4 but that's okay.
A more general VisitRegs API is much more powerful and useful and less specialized.
PR to integrate |
A new take of #1148.
Advantages
Display
impl forInstruction
Instruction
during executionPrecursors
These precursor PRs simplify the final integration of the new
wasmi_ir
crate.wasmi_ir
crate into thewasmi
crate:call_indirect
instructions in the old Wasmi translator & executor.call_indirect
instructions #1156select
instructions in the old Wasmi translator & executor.select
instructions #1157br_table
instructions in the old Wasmi translator & executor.br_table
instructions #1158Register[Span[Iter]]
toReg[Span[Iter]]
.Register[Span[Iter]]
toReg[Span[Iter]]
#1160Reg::{from_i16, to_i16}
methods.Reg::{from_i16, to_i16}
methods #1161wasmi
crate for newInstruction
enum usage.Instruction
variants #1162load
instructions #1163store
instructions #1164{Elem,Data}Drop
instructions #1182wasmi
crateengine
sub-module structurally.Const32<u32>
usage #1168InstructionPtr
into the executor sub-module #1169provider
module into thetranslator
module #1170relink_result
implementation #1179RegSpanIter
withBoundedRegSpan
#1180wasmi_ir
related types #1181index
submodule inbytecode
module #1183