Skip to content

Use named fields for Wasmi load instructions #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Sep 4, 2024

This will help simplify the integration of #1152.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 40.29126% with 123 lines in your changes missing coverage. Please review.

Project coverage is 79.01%. Comparing base (bb031ed) to head (75a221c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/wasmi/src/engine/executor/instrs.rs 50.00% 56 Missing ⚠️
...ates/wasmi/src/engine/translator/visit_register.rs 0.00% 42 Missing ⚠️
...rates/wasmi/src/engine/translator/relink_result.rs 42.85% 24 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/load.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1163      +/-   ##
==========================================
- Coverage   79.17%   79.01%   -0.16%     
==========================================
  Files         296      296              
  Lines       25400    25438      +38     
==========================================
- Hits        20111    20101      -10     
- Misses       5289     5337      +48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop
Copy link
Member Author

Robbepop commented Sep 4, 2024

The Miri (spec) CI job fails because it timed out. This is a known issue and we need to either change what the job tests via Miri or increase the timeout limit to fix the flakiness.

@Robbepop Robbepop merged commit 82d7fae into main Sep 4, 2024
15 of 18 checks passed
@Robbepop Robbepop deleted the rf-adjust-wasmi-load-instrs branch September 4, 2024 14:51
@Robbepop Robbepop mentioned this pull request Sep 12, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant