Skip to content

Use named field for Wasmi store instructions #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Sep 4, 2024

Simplifies integration of #1152.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 72 lines in your changes missing coverage. Please review.

Project coverage is 79.05%. Comparing base (82d7fae) to head (e7bddc2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ates/wasmi/src/engine/translator/visit_register.rs 0.00% 41 Missing ⚠️
crates/wasmi/src/engine/executor/instrs.rs 65.75% 25 Missing ⚠️
crates/wasmi/src/engine/executor/instrs/store.rs 61.53% 5 Missing ⚠️
...rates/wasmi/src/engine/translator/relink_result.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1164      +/-   ##
==========================================
+ Coverage   79.01%   79.05%   +0.03%     
==========================================
  Files         296      296              
  Lines       25438    25418      -20     
==========================================
- Hits        20101    20095       -6     
+ Misses       5337     5323      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop merged commit 01b17c4 into main Sep 4, 2024
17 of 18 checks passed
@Robbepop Robbepop deleted the rf-adjust-wasmi-store-instrs branch September 4, 2024 15:38
@Robbepop Robbepop mentioned this pull request Sep 12, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant