-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Expose musl/libc++/clang toolchain externally #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks @LucioFranco. I like this idea. The cross-lang LTO was actually disabled later because |
This is a naive question, but would that actually benefit other Rust developers, or is it highly specific to Vector? |
Please ignore my comment, I just read the conversation on the PR 😄 |
Additionally, I think we can unify it with the builder for |
@a-rodin does clang support changing its target like rustc can? Meaning we can build multiple toolchains into the image? |
Clang itself supports, although the libraries would need to be put into separate prefixes. However, I was thinking about having a single Dockerfile, but two images that are built with different build args, probably in CI. |
Also, with multi-arch support in place we would be able to easily create builders for |
Yeah, that makes sense! |
I've created a repository https://github.com/timberio/rust-toolchain. For now it contains only a Dockerfile which can be built with different args, the idea is to use supply different in CircleCI to create images for different target architectures. |
Re-opening this since we want to move these images into the Vector repo and re-build the images each night (or maintain them in some way) |
Noting, this should be part of our migration to GH actions. |
Marking this as low priority since we seem to be moving towards Glibc builds. |
Closing this since we're moving to glibc. |
@a-rodin has built a pretty fantastic toolchain image that can compile rust binaries that include c++/c dependencies with cross-lang lto. This is something that is non-trivial and could benefit the wider rust community.
I suggest that we create a separate repo to keep track of this toolchain image and then have vectors specific builder add the dependencies like OpenSSL. This would also benefit us in the fact that we would not need to rebuild the whole image compiling llvm, rustc, and clang each time we would like to add a new dependency to the build/release process.
Reference #945 (comment)
The text was updated successfully, but these errors were encountered: