Skip to content

chore(operations): Add git to musl build image #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2019
Merged

Conversation

binarylogic
Copy link
Contributor

This adds git to the musl build image, otherwise CI cannot checkout the code properly.

cc @a-rodin

@binarylogic
Copy link
Contributor Author

I don't understand why Circle is still complaining that git does not exist 😦

Either git or ssh (required by git to clone through SSH) is not installed in the image. Falling back to CircleCI's native git client but the behavior may be different from official git. If this is an issue, please use an image that has official git and ssh installed.

https://circleci.com/gh/timberio/vector/16540?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@binarylogic
Copy link
Contributor Author

@a-rodin I'm having trouble building this image locally. I'm curious how you build this image successfully? I assume you are not on a Mac?

Related, #946 should resolve that, correct? Enabling us to just rebuild the last step in the Docker file.

@ghost
Copy link

ghost commented Oct 9, 2019

@binarylogic I build it on Linux, however I suspect that the reason it fails for you is that the Docker VM doesn't have enough RAM allocated to it because linking Clang is rather memory-intensive.

Related, #946 should resolve that, correct? Enabling us to just rebuild the last step in the Docker file.

Yes, it should. In addition, we can unify base builders for x86_64-unknown-linux-musl and armv7-unknown-linux-musleabihf. I was experimenting with the latter recently and was able to compile Vector without default features for armv7-unknown-linux-musleabihf.

@LucioFranco
Copy link
Contributor

VM doesn't have enough RAM allocated to it because linking Clang is rather memory-intensive.

This is the issue, using cgroups directly is much better than going through a VM which docker for mac and windows do.

@LucioFranco
Copy link
Contributor

That said, we can build the toolchain images separately from the dependencies required at build time. This is the goal of #946, so that we don't need to rebuild llvm, clang, rustc each time we want to add git etc.

@binarylogic binarylogic merged commit a70603d into master Oct 9, 2019
@binarylogic binarylogic deleted the musl-git branch October 9, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants