Skip to content

chore: Use stable Rust 1.38.0 and update Linux headers for x86_6… #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from Oct 1, 2019
Merged

Conversation

ghost
Copy link

@ghost ghost commented Sep 27, 2019

No description provided.

@LucioFranco
Copy link
Contributor

@a-rodin can we break out the toolchain build part of this and the part that adds the dependencies for vector? We could probably at some point extract our musl toolchain so that others can use it. What do you think?

@ghost
Copy link
Author

ghost commented Sep 27, 2019

@LucioFranco Actually this builder is already not very Vector-specific. The only part that can be considered external is OpenSSL, which can be extracted easily (but those who want to use OpenSSL available for C libraries would need to do the same patching as we do here in order to compile it).

The idea of making it available for use by others is great. I think it might be worth to decide how is it going to be shared to clarify requirements for that toolchain image. I see three approaches:

  • keep it in Vector's repository, but separated and published to Docker Hub;
  • keep it in a separate repository;
  • try to push it to be an official Rust musl/libc++/clang toolchain image.

@LucioFranco
Copy link
Contributor

@a-rodin I created #946 to track this, we can move discussion there.

@LucioFranco
Copy link
Contributor

We need to build the image and push it before we merge this PR.

@LucioFranco
Copy link
Contributor

@a-rodin Image is being built right now. I moved the patch into the root dir of the builder images since that is where docker loads the context when running build-ci-images.sh.

@LucioFranco
Copy link
Contributor

New image has been pushed.

@LucioFranco LucioFranco changed the title chore: Use stable Rust 1.38.0 and update Linux headers for x86_64-unknown-linux-musl builder chore: Use stable Rust 1.38.0 and update Linux headers for x86_6… Oct 1, 2019
@LucioFranco LucioFranco merged commit 07339e1 into vectordotdev:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants