-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore: Use stable Rust 1.38.0 and update Linux headers for x86_6… #945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Alexander Rodin <[email protected]>
Signed-off-by: Alexander Rodin <[email protected]>
@a-rodin can we break out the toolchain build part of this and the part that adds the dependencies for vector? We could probably at some point extract our musl toolchain so that others can use it. What do you think? |
Signed-off-by: Alexander Rodin <[email protected]>
@LucioFranco Actually this builder is already not very Vector-specific. The only part that can be considered external is OpenSSL, which can be extracted easily (but those who want to use OpenSSL available for C libraries would need to do the same patching as we do here in order to compile it). The idea of making it available for use by others is great. I think it might be worth to decide how is it going to be shared to clarify requirements for that toolchain image. I see three approaches:
|
We need to build the image and push it before we merge this PR. |
Signed-off-by: Lucio Franco <[email protected]>
@a-rodin Image is being built right now. I moved the patch into the root dir of the builder images since that is where docker loads the context when running |
New image has been pushed. |
No description provided.