Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5512 Handle feedback #5212

Merged
merged 75 commits into from
Aug 16, 2024
Merged
Show file tree
Hide file tree
Changes from 72 commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
3592729
5512: remove petition redaction acknowledgement from Electronic petit…
nechama-krigsman Jul 25, 2024
013f0e2
5512: Extracted the 'N/A' constant to Entity Constant file;
nechama-krigsman Jul 25, 2024
0ebe557
5512: use useEffect instead of local variable;
nechama-krigsman Jul 25, 2024
ca932fa
5512: Extracted React components from Step 6 to own files;
nechama-krigsman Jul 25, 2024
8375cc7
5512: Extracted React components from Step 1 to own files;
nechama-krigsman Jul 25, 2024
6c5eb78
5512: Remove Comment;
nechama-krigsman Jul 25, 2024
d11a7b7
Merge branch '5512-story' into 5512-story-updates
nechama-krigsman Jul 25, 2024
09e6530
Merge branch '5512-story' into 5512-story-updates
nechama-krigsman Jul 25, 2024
ee9bf90
5512: move logic to generate case description based off of original c…
nechama-krigsman Jul 25, 2024
69d94f9
5512: Use empty HTML tags instead of React.Fragment tags;
nechama-krigsman Jul 25, 2024
959f587
5512: rename get data actions;
nechama-krigsman Jul 25, 2024
0ed4ceb
5512: rename state property where we store data for create a petition…
nechama-krigsman Jul 25, 2024
ea4d90d
5512: rename state property where we store data for create a petition…
nechama-krigsman Jul 25, 2024
ee5a028
5512: rename state property where we store data for create a petition…
nechama-krigsman Jul 25, 2024
0badc94
5512: rename state property where we store data for create a petition…
nechama-krigsman Jul 25, 2024
1177bfd
5512: rename state property where we store data for create a petition…
nechama-krigsman Jul 25, 2024
cbc1344
5512: Refactor out a nested if condition when assigning phone number …
nechama-krigsman Jul 25, 2024
75905dd
5512: add types to updatePetitionFormValueSequence;
nechama-krigsman Jul 25, 2024
6bc8e9a
5512: separate place of legal residence ids with hyphen instead of pe…
nechama-krigsman Jul 26, 2024
8c49af4
5512: rename count prop; updated component types;
nechama-krigsman Jul 26, 2024
b863b1b
5512: refactor default contact state to avoid duplicate code;
nechama-krigsman Jul 26, 2024
be6281e
5512: remove destructuring to be consistent;
nechama-krigsman Jul 26, 2024
120b358
5512: rename variable for clarity;
nechama-krigsman Jul 26, 2024
57dc871
5512: Add new lines;
Jul 26, 2024
9615df3
5512: Update how we check for errors;
Jul 26, 2024
fb9568d
Merge branch '5512-story-updates' of github.com:flexion/ef-cms into 5…
Jul 26, 2024
db35aee
5512: Use existing setFormValueAction;
Jul 26, 2024
808b866
5512: Refactor action;
Jul 26, 2024
ee3047b
5512: Extend unit test coverage of action;
Jul 26, 2024
6226509
5512: Refactor action to reduce code duplication;
Jul 26, 2024
1d23869
5512: Refactor action for better naming;
Jul 26, 2024
1c3078d
5512: Make sure we return after calling the error path in action;
Jul 26, 2024
97072a9
5512: extract focus validation logic to helper; add tests;
nechama-krigsman Jul 29, 2024
9cc2202
Merge branch '5512-story-updates' of https://github.com/flexion/ef-cm…
nechama-krigsman Jul 29, 2024
dc21b6e
5512: remove inline style on petition facts and reasons;
nechama-krigsman Jul 29, 2024
a2d32c8
5512: add types for PetitionPdf; Remove date formatting as data alrea…
nechama-krigsman Jul 29, 2024
c4916b6
5512: generate keys combining property and index to replace potential…
nechama-krigsman Jul 29, 2024
e1528af
5512: move PETITION_TYPES to entity constants;
nechama-krigsman Jul 29, 2024
daf35d6
5512: Typing the Petition Generation flow; update Tests;
nechama-krigsman Jul 30, 2024
768a1a7
5512: a11y tests step 1;
nechama-krigsman Jul 30, 2024
72338c5
5512: a11y tests step 2;
nechama-krigsman Jul 30, 2024
29caf28
5512: Create accessibility tests for petition generation flow;
Jul 30, 2024
8575ca2
5512: Use helper function to fill step 1 information;
Jul 30, 2024
525bb69
5512: Use Entity to make sure data is correct for the generatePetitio…
Jul 30, 2024
6f52335
5512: accessibility test step 7 and welcome page;
nechama-krigsman Jul 31, 2024
f76dea3
5512: update tests around generatePetitionPdfAction;
nechama-krigsman Jul 31, 2024
c8ef44b
5512: add tests around GeneratePetitionPdf entity;
nechama-krigsman Jul 31, 2024
9b3c2e1
5512: fix key causing text component to remount and lose focus;
nechama-krigsman Jul 31, 2024
678d536
5512: fix petition facts and reasons textbox not displaying when user…
nechama-krigsman Jul 31, 2024
36672f7
5512: remove duplicate sequence;
nechama-krigsman Jul 31, 2024
f8e34c8
5512: unit test tweak, remove comment
TomElliottFlexion Aug 1, 2024
512e663
5512: use constants for validating countryType and partyType
nechama-krigsman Aug 1, 2024
0684394
5512: we dont need to manually remove top level validation messages s…
nechama-krigsman Aug 1, 2024
6632b29
5512: fix tests;
nechama-krigsman Aug 1, 2024
143fbf1
5512: remove unused component; remove redundant check to show other f…
nechama-krigsman Aug 2, 2024
5d1579f
5512: move petition reason and fact formatting to new action;
nechama-krigsman Aug 2, 2024
57be8e7
5512: remove unused action; we are using clearAddressFieldsAction ins…
nechama-krigsman Aug 2, 2024
cdda04f
5512: add tests around updateIrsNoticeIndexPropertyAction;
nechama-krigsman Aug 2, 2024
58e222d
5512: use irsNotices properties directly instead of separate variables;
nechama-krigsman Aug 2, 2024
7bf3579
5512: remove test since logic was moved to new action formatPetitionF…
nechama-krigsman Aug 5, 2024
c6da04e
5512: remove unused state;
nechama-krigsman Aug 5, 2024
39e47a1
5512: remove field since we are using irsNotices properties directly;
nechama-krigsman Aug 5, 2024
876323c
5512: shorten key length in petition reasons and facts;
nechama-krigsman Aug 5, 2024
86404ae
Merge branch 'staging' into 5512-story-updates
nechama-krigsman Aug 5, 2024
df63c38
5512: include case types Disclosure1 and Disclosure2 in entity valida…
nechama-krigsman Aug 7, 2024
24c02dc
5512: update character limit and validation message for cityAndStateI…
nechama-krigsman Aug 7, 2024
09fd830
5512: fix tests and type errors;
nechama-krigsman Aug 7, 2024
0e0ea75
5512: update test to use casetypes we display in the dropdown;
nechama-krigsman Aug 7, 2024
819f35c
Merge branch 'staging' into 5512-story-updates
nechama-krigsman Aug 7, 2024
5f79e5b
Merge branch 'staging' into 5512-story-updates
nechama-krigsman Aug 12, 2024
1be0a89
Merge branch 'staging' into 5512-story-updates
nechama-krigsman Aug 14, 2024
381bcef
Merge branch 'staging' into 5512-story-updates
jimlerza Aug 15, 2024
8a039f8
5512: fix type errors;
nechama-krigsman Aug 15, 2024
3ff0b07
Merge branch 'staging' into 5512-story-updates
jimlerza Aug 15, 2024
fc6408f
Merge branch 'staging' into 5512-story-updates
jimlerza Aug 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cypress/helpers/authentication/login-as-helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export function loginAsIrsPractitioner1() {
}

export function loginAsPetitioner(
petitionerUser: 'petitioner' | 'petitioner1' = 'petitioner1',
petitionerUser: 'petitioner' | 'petitioner1' | 'petitioner7' = 'petitioner1',
) {
cy.login(petitionerUser);
cy.get('[data-testid="file-a-petition"]').should('exist');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export function petitionerCreatesElectronicCaseUpdated(
cy.get('[data-testid="contactPrimary.city"]').type('Orlando');
cy.get('[data-testid="contactPrimary.state"]').select('AL');
cy.get('[data-testid="contactPrimary.postalCode"]').type('12345');
cy.get('[data-testid="contactPrimary.placeOfLegalResidence"]').select('AL');
cy.get('[data-testid="contactPrimary-placeOfLegalResidence"]').select('AL');
cy.get('[data-testid="contact-primary-phone"]').type('1111111111');
cy.get('[data-testid="step-1-next-button"]').click();

Expand Down Expand Up @@ -105,7 +105,7 @@ export function petitionerAttemptsToUploadCorruptPdfUpdated() {
cy.get('[data-testid="contactPrimary.city"]').type('Orlando');
cy.get('[data-testid="contactPrimary.state"]').select('AL');
cy.get('[data-testid="contactPrimary.postalCode"]').type('12345');
cy.get('[data-testid="contactPrimary.placeOfLegalResidence"]').select('AL');
cy.get('[data-testid="contactPrimary-placeOfLegalResidence"]').select('AL');
cy.get('[data-testid="contact-primary-phone"]').type('1111111111');
cy.get('[data-testid="step-1-next-button"]').click();

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { checkA11y } from '../../../support/generalCommands/checkA11y';
import { loginAsPetitioner } from '../../../../helpers/authentication/login-as-helpers';

describe('Petition generation - intro pages', () => {
it('welcome to dawson: should be free of a11y issues', () => {
loginAsPetitioner('petitioner7');
checkA11y();
});

it('before filing a case: should be free of a11y issues', () => {
loginAsPetitioner();
cy.visit('/before-filing-a-petition');
checkA11y();
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,146 @@
import { checkA11y } from '../../../support/generalCommands/checkA11y';
import { loginAsPetitioner } from '../../../../helpers/authentication/login-as-helpers';

describe('Petition generation - step 1', () => {
beforeEach(() => {
loginAsPetitioner();
cy.visit('/file-a-petition/new');
});

describe('Myself', () => {
it('Myself - domestic: should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-0"').click();
checkA11y();
});

it('Myself - international: should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-0"').click();
cy.get('[data-testid="international-country-btn"]').click();
checkA11y();
});
});
describe('Myself and my spouse', () => {
it('Myself and my spouse - deceased: should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-1"').click();
cy.get('[data-testid="is-spouse-deceased-0"]').click();
checkA11y();
});

it('Myself and my spouse - not deceased: should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-1"').click();
cy.get('[data-testid="is-spouse-deceased-1"]').click();
cy.get('[data-testid="have-spouse-consent-label"').click();
checkA11y();
});
});
describe('Business', () => {
it('Corporation: should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-2"').click();
cy.get('.business-type-radio-option').eq(0).click();
checkA11y();
});

it('Partnership (as the Tax Matters Partner): should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-2"').click();
cy.get('.business-type-radio-option').eq(1).click();
checkA11y();
});

it('Partnership (as a partner other than Tax Matters Partner): should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-2"').click();
cy.get('.business-type-radio-option').eq(2).click();
checkA11y();
});

it('Partnership (as a partnership representative under BBA): should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-2"').click();
cy.get('.business-type-radio-option').eq(3).click();
checkA11y();
});
});
describe('Other', () => {
describe('An estate or trust', () => {
it('Estate with an executor/personal representative/fiduciary/etc.: should be free of a11y issues: should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-3"').click();
cy.get('[data-testid="other-type-radio-option-0"]').click();
cy.get('[data-testid="estate-type-radio-option-0"]').click();
checkA11y();
});

it('Estate without an executor/personal representative/fiduciary/etc.: should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-3"').click();
cy.get('[data-testid="other-type-radio-option-0"]').click();
cy.get('[data-testid="estate-type-radio-option-1"]').click();
checkA11y();
});

it('Trust: should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-3"').click();
cy.get('[data-testid="other-type-radio-option-0"]').click();
cy.get('[data-testid="estate-type-radio-option-2"]').click();
checkA11y();
});
});

describe('A minor or legally incompetent person', () => {
it('Conservator: should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-3"').click();
cy.get('[data-testid="other-type-radio-option-1"]').click();
cy.get('[data-testid="minor-incompetent-type-radio-option-0"]').click();
checkA11y();
});

it('Guardian: should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-3"').click();
cy.get('[data-testid="other-type-radio-option-1"]').click();
cy.get('[data-testid="minor-incompetent-type-radio-option-1"]').click();
checkA11y();
});

it('Custodian: should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-3"').click();
cy.get('[data-testid="other-type-radio-option-1"]').click();
cy.get('[data-testid="minor-incompetent-type-radio-option-2"]').click();
checkA11y();
});

it('Next friend for a minor (without a guardian, conservator, or other like fiduciary): should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-3"').click();
cy.get('[data-testid="other-type-radio-option-1"]').click();
cy.get('[data-testid="minor-incompetent-type-radio-option-3"]').click();
checkA11y();
});

it('Next friend for a legally incompetent person (without a guardian, conservator, or other like fiduciary): should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-3"').click();
cy.get('[data-testid="other-type-radio-option-1"]').click();
cy.get('[data-testid="minor-incompetent-type-radio-option-4"]').click();
checkA11y();
});
});

describe('Donor', () => {
it('Donor: should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-3"').click();
cy.get('[data-testid="other-type-radio-option-2"]').click();
checkA11y();
});
});

describe('Transferee', () => {
it('Transferee: should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-3"').click();
cy.get('[data-testid="other-type-radio-option-3"]').click();
checkA11y();
});
});

describe('Deceased Spouse', () => {
it('Deceased Spouse: should be free of a11y issues', () => {
cy.get('[data-testid="filing-type-3"').click();
cy.get('[data-testid="other-type-radio-option-4"]').click();
checkA11y();
});
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { checkA11y } from '../../../support/generalCommands/checkA11y';
import { fillPetitionerInformation } from '../../integration/fileAPetitionUpdated/petition-helper';
import { loginAsPetitioner } from '../../../../helpers/authentication/login-as-helpers';

describe('Petition generation - step 2', () => {
beforeEach(() => {
loginAsPetitioner();
cy.visit('/file-a-petition/new');
fillPetitionerInformation();
});

it('Auto generate Petition: should be free of a11y issues', () => {
cy.get('[data-testid="add-another-reason-link-button"').click();
cy.get('[data-testid="add-another-fact-link-button"').click();
checkA11y();
});

it('Upload PDF Petition: should be free of a11y issues', () => {
cy.get('[data-testid="upload-a-petition-label"').click();
checkA11y();
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import { checkA11y } from '../../../support/generalCommands/checkA11y';
import {
fillPetitionFileInformation,
fillPetitionerInformation,
} from '../../integration/fileAPetitionUpdated/petition-helper';
import { loginAsPetitioner } from '../../../../helpers/authentication/login-as-helpers';

describe('Petition generation - step 3', () => {
const VALID_FILE = '../../helpers/file/sample.pdf';

beforeEach(() => {
loginAsPetitioner();
cy.visit('/file-a-petition/new');
fillPetitionerInformation();
fillPetitionFileInformation(VALID_FILE);
});

it('IRS Notice Provided: should be free of a11y issues', () => {
cy.get('[data-testid="irs-notice-Yes"]').click();
checkA11y();
});

it('IRS Notice not Provided: should be free of a11y issues', () => {
cy.get('[data-testid="irs-notice-No"]').click();
checkA11y();
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { checkA11y } from '../../../support/generalCommands/checkA11y';
import {
fillIrsNoticeInformation,
fillPetitionFileInformation,
fillPetitionerInformation,
} from '../../integration/fileAPetitionUpdated/petition-helper';
import { loginAsPetitioner } from '../../../../helpers/authentication/login-as-helpers';

describe('Petition generation - step 4', () => {
const VALID_FILE = '../../helpers/file/sample.pdf';

beforeEach(() => {
loginAsPetitioner();
cy.visit('/file-a-petition/new');
fillPetitionerInformation();
fillPetitionFileInformation(VALID_FILE);
fillIrsNoticeInformation(VALID_FILE);
});

it('Regular Case: should be free of a11y issues', () => {
checkA11y();
});

it('Small Case: should be free of a11y issues', () => {
cy.get('[data-testid="procedure-type-1"]').click();
checkA11y();
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import { checkA11y } from '../../../support/generalCommands/checkA11y';
import {
fillCaseProcedureInformation,
fillIrsNoticeInformation,
fillPetitionFileInformation,
fillPetitionerInformation,
} from '../../integration/fileAPetitionUpdated/petition-helper';
import { loginAsPetitioner } from '../../../../helpers/authentication/login-as-helpers';

describe('Petition generation - step 5', () => {
const VALID_FILE = '../../helpers/file/sample.pdf';

beforeEach(() => {
loginAsPetitioner();
cy.visit('/file-a-petition/new');
fillPetitionerInformation();
fillPetitionFileInformation(VALID_FILE);
fillIrsNoticeInformation(VALID_FILE);
fillCaseProcedureInformation();
});

it('Upload STIN: should be free of a11y issues', () => {
checkA11y();
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import { checkA11y } from '../../../support/generalCommands/checkA11y';
import {
fillCaseProcedureInformation,
fillIrsNoticeInformation,
fillPetitionFileInformation,
fillPetitionerInformation,
fillStinInformation,
} from '../../integration/fileAPetitionUpdated/petition-helper';
import { loginAsPetitioner } from '../../../../helpers/authentication/login-as-helpers';

describe('Petition generation - step 6', () => {
const VALID_FILE = '../../helpers/file/sample.pdf';

beforeEach(() => {
loginAsPetitioner();
cy.visit('/file-a-petition/new');
fillPetitionerInformation();
fillPetitionFileInformation(VALID_FILE);
fillIrsNoticeInformation(VALID_FILE);
fillCaseProcedureInformation();
fillStinInformation(VALID_FILE);
});

it('Review Page: should be free of a11y issues', () => {
checkA11y();
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import { checkA11y } from '../../../support/generalCommands/checkA11y';
import {
fillCaseProcedureInformation,
fillIrsNoticeInformation,
fillPetitionFileInformation,
fillPetitionerInformation,
fillStinInformation,
} from '../../integration/fileAPetitionUpdated/petition-helper';
import { loginAsPetitioner } from '../../../../helpers/authentication/login-as-helpers';

describe('Petition generation - step 7', () => {
const VALID_FILE = '../../helpers/file/sample.pdf';

beforeEach(() => {
loginAsPetitioner();
cy.visit('/file-a-petition/new');
fillPetitionerInformation();
fillPetitionFileInformation(VALID_FILE);
fillIrsNoticeInformation(VALID_FILE);
fillCaseProcedureInformation();
fillStinInformation(VALID_FILE);
cy.get('[data-testid="step-6-next-button"]').click();
});

it('Pay filing fee: should be free of a11y issues', () => {
cy.intercept('POST', '**/cases').as('postCase');
cy.wait('@postCase').then(() => {
checkA11y();
});
});
});
Loading
Loading