5512 Handle feedback #5212
Merged
5512 Handle feedback #5212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion since it doesnt save to the DB and its validated on the frontend (keep legacy pattern);
…ase type; updated unit tests;
…for secondary contact;
…512-story-updates
…actsAndReasonsAction
…tion; remove unused field taxYear;
…ssuingOffice to be consistent with the other fields;
cruzjone-flexion
approved these changes
Aug 12, 2024
| @@ -178,11 +174,6 @@ export class ElectronicPetition extends JoiValidationEntity { | |||
| '*': 'Your Petition file size is empty', | |||
| 'number.max': `Your Petition file size is too big. The maximum file size is ${MAX_FILE_SIZE_MB}MB.`, | |||
| }), | |||
| petitionRedactionAcknowledgement: joi.boolean().when('petitionType', { | |||
There was a problem hiding this comment.
Is there any harm in leaving this in since it'll be added back with 10339? Not a whole lot of point in validating something we don't save here, but also not a whole lot of point in removing it
| @@ -1622,6 +1623,11 @@ export const JUDGE_TITLES = [ | |||
| ] as const; | |||
| export type JudgeTitle = (typeof JUDGE_TITLES)[number]; | |||
|
|
|||
| export const PETITION_TYPES = { | |||
TomElliottFlexion
approved these changes
Aug 15, 2024
jimlerza
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.