Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5512 Handle feedback #5212

Merged
merged 75 commits into from
Aug 16, 2024
Merged

5512 Handle feedback #5212

merged 75 commits into from
Aug 16, 2024

Commits on Jul 25, 2024

  1. 5512: remove petition redaction acknowledgement from Electronic petit… 

    …ion since it doesnt save to the DB and its validated on the frontend (keep legacy pattern);
    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    3592729 View commit details
    Browse the repository at this point in the history

  2. 5512: Extracted the 'N/A' constant to Entity Constant file;

    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    013f0e2 View commit details
    Browse the repository at this point in the history

  3. 5512: use useEffect instead of local variable;

    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0ebe557 View commit details
    Browse the repository at this point in the history

  4. 5512: Extracted React components from Step 6 to own files;

    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ca932fa View commit details
    Browse the repository at this point in the history

  5. 5512: Extracted React components from Step 1 to own files;

    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    8375cc7 View commit details
    Browse the repository at this point in the history

  6. 5512: Remove Comment;

    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    6c5eb78 View commit details
    Browse the repository at this point in the history

  7. Merge branch '5512-story' into 5512-story-updates

    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d11a7b7 View commit details
    Browse the repository at this point in the history

  8. Merge branch '5512-story' into 5512-story-updates

    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    09e6530 View commit details
    Browse the repository at this point in the history

  9. 5512: move logic to generate case description based off of original c… 

    …ase type; updated unit tests;
    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ee9bf90 View commit details
    Browse the repository at this point in the history

  10. 5512: Use empty HTML tags instead of React.Fragment tags;

    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    69d94f9 View commit details
    Browse the repository at this point in the history

  11. 5512: rename get data actions;

    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    959f587 View commit details
    Browse the repository at this point in the history

  12. 5512: rename state property where we store data for create a petition… 

    … step #1;
    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0ed4ceb View commit details
    Browse the repository at this point in the history

  13. 5512: rename state property where we store data for create a petition… 

    … step #2;
    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ea4d90d View commit details
    Browse the repository at this point in the history

  14. 5512: rename state property where we store data for create a petition… 

    … step #3;
    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ee5a028 View commit details
    Browse the repository at this point in the history

  15. 5512: rename state property where we store data for create a petition… 

    … step #4;
    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0badc94 View commit details
    Browse the repository at this point in the history

  16. 5512: rename state property where we store data for create a petition… 

    … step #5;
    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1177bfd View commit details
    Browse the repository at this point in the history

  17. 5512: Refactor out a nested if condition when assigning phone number … 

    …for secondary contact;
    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    cbc1344 View commit details
    Browse the repository at this point in the history

  18. 5512: add types to updatePetitionFormValueSequence;

    @nechama-krigsman
    nechama-krigsman committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    75905dd View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. 5512: separate place of legal residence ids with hyphen instead of pe… 

    …riods;
    @nechama-krigsman
    nechama-krigsman committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6bc8e9a View commit details
    Browse the repository at this point in the history

  2. 5512: rename count prop; updated component types;

    @nechama-krigsman
    nechama-krigsman committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    8c49af4 View commit details
    Browse the repository at this point in the history

  3. 5512: refactor default contact state to avoid duplicate code;

    @nechama-krigsman
    nechama-krigsman committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    b863b1b View commit details
    Browse the repository at this point in the history

  4. 5512: remove destructuring to be consistent;

    @nechama-krigsman
    nechama-krigsman committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    be6281e View commit details
    Browse the repository at this point in the history

  5. 5512: rename variable for clarity;

    @nechama-krigsman
    nechama-krigsman committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    120b358 View commit details
    Browse the repository at this point in the history

  6. 5512: Add new lines;

    John Cruz committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    57dc871 View commit details
    Browse the repository at this point in the history

  7. 5512: Update how we check for errors;

    John Cruz committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    9615df3 View commit details
    Browse the repository at this point in the history

  8. Merge branch '5512-story-updates' of github.com:flexion/ef-cms into 5… 

    …512-story-updates
    John Cruz committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    fb9568d View commit details
    Browse the repository at this point in the history

  9. 5512: Use existing setFormValueAction;

    John Cruz committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    db35aee View commit details
    Browse the repository at this point in the history

  10. 5512: Refactor action;

    John Cruz committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    808b866 View commit details
    Browse the repository at this point in the history

  11. 5512: Extend unit test coverage of action;

    John Cruz committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    ee3047b View commit details
    Browse the repository at this point in the history

  12. 5512: Refactor action to reduce code duplication;

    John Cruz committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    6226509 View commit details
    Browse the repository at this point in the history

  13. 5512: Refactor action for better naming;

    John Cruz committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    1d23869 View commit details
    Browse the repository at this point in the history

  14. 5512: Make sure we return after calling the error path in action;

    John Cruz committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    1c3078d View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. 5512: extract focus validation logic to helper; add tests;

    @nechama-krigsman
    nechama-krigsman committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    97072a9 View commit details
    Browse the repository at this point in the history

  2. Merge branch '5512-story-updates' of https://github.com/flexion/ef-cms … 

    …into 5512-story-updates
    @nechama-krigsman
    nechama-krigsman committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    9cc2202 View commit details
    Browse the repository at this point in the history

  3. 5512: remove inline style on petition facts and reasons;

    @nechama-krigsman
    nechama-krigsman committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    dc21b6e View commit details
    Browse the repository at this point in the history

  4. 5512: add types for PetitionPdf; Remove date formatting as data alrea… 

    …dy exists;
    @nechama-krigsman
    nechama-krigsman committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    a2d32c8 View commit details
    Browse the repository at this point in the history

  5. 5512: generate keys combining property and index to replace potential… 

    … long keys;
    @nechama-krigsman
    nechama-krigsman committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    c4916b6 View commit details
    Browse the repository at this point in the history

  6. 5512: move PETITION_TYPES to entity constants;

    @nechama-krigsman
    nechama-krigsman committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    e1528af View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. 5512: Typing the Petition Generation flow; update Tests;

    @nechama-krigsman
    nechama-krigsman committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    daf35d6 View commit details
    Browse the repository at this point in the history

  2. 5512: a11y tests step 1;

    @nechama-krigsman
    nechama-krigsman committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    768a1a7 View commit details
    Browse the repository at this point in the history

  3. 5512: a11y tests step 2;

    @nechama-krigsman
    nechama-krigsman committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    72338c5 View commit details
    Browse the repository at this point in the history

  4. 5512: Create accessibility tests for petition generation flow;

    John Cruz committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    29caf28 View commit details
    Browse the repository at this point in the history

  5. 5512: Use helper function to fill step 1 information;

    John Cruz committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    8575ca2 View commit details
    Browse the repository at this point in the history

  6. 5512: Use Entity to make sure data is correct for the generatePetitio… 

    …nPdfInteractor;
    John Cruz committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    525bb69 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. 5512: accessibility test step 7 and welcome page;

    @nechama-krigsman
    nechama-krigsman committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    6f52335 View commit details
    Browse the repository at this point in the history

  2. 5512: update tests around generatePetitionPdfAction;

    @nechama-krigsman
    nechama-krigsman committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    f76dea3 View commit details
    Browse the repository at this point in the history

  3. 5512: add tests around GeneratePetitionPdf entity;

    @nechama-krigsman
    nechama-krigsman committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    c8ef44b View commit details
    Browse the repository at this point in the history

  4. 5512: fix key causing text component to remount and lose focus;

    @nechama-krigsman
    nechama-krigsman committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    9b3c2e1 View commit details
    Browse the repository at this point in the history

  5. 5512: fix petition facts and reasons textbox not displaying when user… 

    … deletes text;
    @nechama-krigsman
    nechama-krigsman committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    678d536 View commit details
    Browse the repository at this point in the history

  6. 5512: remove duplicate sequence;

    @nechama-krigsman
    nechama-krigsman committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    36672f7 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. 5512: unit test tweak, remove comment

    @TomElliottFlexion
    TomElliottFlexion committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    f8e34c8 View commit details
    Browse the repository at this point in the history

  2. 5512: use constants for validating countryType and partyType

    @nechama-krigsman
    nechama-krigsman committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    512e663 View commit details
    Browse the repository at this point in the history

  3. 5512: we dont need to manually remove top level validation messages s… 

    …ince we no longer use the ErrorAlert component; display validation message for city and state issuing office; remove comments;
    @nechama-krigsman
    nechama-krigsman committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0684394 View commit details
    Browse the repository at this point in the history

  4. 5512: fix tests;

    @nechama-krigsman
    nechama-krigsman committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    6632b29 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. 5512: remove unused component; remove redundant check to show other f… 

    …iling options;
    @nechama-krigsman
    nechama-krigsman committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    143fbf1 View commit details
    Browse the repository at this point in the history

  2. 5512: move petition reason and fact formatting to new action;

    @nechama-krigsman
    nechama-krigsman committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    5d1579f View commit details
    Browse the repository at this point in the history

  3. 5512: remove unused action; we are using clearAddressFieldsAction ins… 

    …tead;
    @nechama-krigsman
    nechama-krigsman committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    57be8e7 View commit details
    Browse the repository at this point in the history

  4. 5512: add tests around updateIrsNoticeIndexPropertyAction;

    @nechama-krigsman
    nechama-krigsman committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    cdda04f View commit details
    Browse the repository at this point in the history

  5. 5512: use irsNotices properties directly instead of separate variables;

    @nechama-krigsman
    nechama-krigsman committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    58e222d View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. 5512: remove test since logic was moved to new action formatPetitionF… 

    …actsAndReasonsAction
    @nechama-krigsman
    nechama-krigsman committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    7bf3579 View commit details
    Browse the repository at this point in the history

  2. 5512: remove unused state;

    @nechama-krigsman
    nechama-krigsman committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    c6da04e View commit details
    Browse the repository at this point in the history

  3. 5512: remove field since we are using irsNotices properties directly;

    @nechama-krigsman
    nechama-krigsman committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    39e47a1 View commit details
    Browse the repository at this point in the history

  4. 5512: shorten key length in petition reasons and facts;

    @nechama-krigsman
    nechama-krigsman committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    876323c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'staging' into 5512-story-updates

    @nechama-krigsman
    nechama-krigsman committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    86404ae View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. 5512: include case types Disclosure1 and Disclosure2 in entity valida… 

    …tion; remove unused field taxYear;
    @nechama-krigsman
    nechama-krigsman committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    df63c38 View commit details
    Browse the repository at this point in the history

  2. 5512: update character limit and validation message for cityAndStateI… 

    …ssuingOffice to be consistent with the other fields;
    @nechama-krigsman
    nechama-krigsman committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    24c02dc View commit details
    Browse the repository at this point in the history

  3. 5512: fix tests and type errors;

    @nechama-krigsman
    nechama-krigsman committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    09fd830 View commit details
    Browse the repository at this point in the history

  4. 5512: update test to use casetypes we display in the dropdown;

    @nechama-krigsman
    nechama-krigsman committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    0e0ea75 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'staging' into 5512-story-updates

    @nechama-krigsman
    nechama-krigsman committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    819f35c View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Merge branch 'staging' into 5512-story-updates

    @nechama-krigsman
    nechama-krigsman committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    5f79e5b View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge branch 'staging' into 5512-story-updates

    @nechama-krigsman
    nechama-krigsman committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    1be0a89 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Merge branch 'staging' into 5512-story-updates

    @jimlerza
    jimlerza committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    381bcef View commit details
    Browse the repository at this point in the history

  2. 5512: fix type errors;

    @nechama-krigsman
    nechama-krigsman committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    8a039f8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'staging' into 5512-story-updates

    @jimlerza
    jimlerza committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    3ff0b07 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Merge branch 'staging' into 5512-story-updates

    @jimlerza
    jimlerza committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    fc6408f View commit details
    Browse the repository at this point in the history