-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin logger #4
Plugin logger #4
Conversation
Because this needs to run in a worker env it's likely @gitcoindev what would your suggestion be here if it does need replaced? const messageFormatted = typeof message === "string"
? message
: util.inspect(message, { showHidden: true, depth: null, breakLength: Infinity }); |
@Keyrxng The |
https://github.com/ubiquity/ubiquibot-logger/tree/development/dist I was keeping things the same as the dev branch but if that is not wanted I shall remove it. |
I think this was a mistake to commit it because it contains generated |
Agreed and I have included it in the |
@Keyrxng Thank you. Is there any tests associated with the changes in this repo? If not, should definitely nice to have in another PR. |
Resolves #2
It makes sense to remove the direct capability to do this from within the logger itself.
formatting and styling remains the same, when the logger calls
_log
it returns aLogReturn
object which the invoker can use to post or store.I have removed the Supabase and GH comment posting ability completely (can be returned if the need for it exists tho it seems more likely only the kernel should be able to post to SB and comment control is on a per-plugin basis and this should be a simple runtime logger and nothing more)