Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge development into main #10

Merged
merged 97 commits into from
Jul 4, 2024
Merged

Merge development into main #10

merged 97 commits into from
Jul 4, 2024

Conversation

gentlementlegen
Copy link
Member

No description provided.

@gentlementlegen gentlementlegen marked this pull request as ready for review June 24, 2024 08:33
Copy link
Contributor

github-actions bot commented Jun 24, 2024

Lines Statements Branches Functions
Coverage: 40%
36.9% (186/504) 10.93% (21/192) 32.14% (27/84)

JUnit

Tests Skipped Failures Errors Time
4 0 💤 0 ❌ 0 🔥 5.399s ⏱️
Coverage Report (40%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files36.910.9332.1440.26 
src73.0133.3345.4572.13 
   run.ts59.252016.6659.2523–35, 46–51, 56
   worker.ts83.33508082.3517, 36, 45–53
src/adapters100100100100 
   index.ts100100100100 
src/adapters/supabase/helpers/tables39.02054.5444.44 
   access.ts27.7705031.2514–26, 31, 43–50
   label.ts200252527–54
   super.ts100100100100 
   user.ts100100100100 
src/handlers31.3310.6321.9534.11 
   command-parser.ts79.316071.4279.3122, 29, 32, 40, 65, 71
   comment.ts8036.3610082.0510, 20–23, 30, 38, 73
   handle-parent-issue.ts35.710041.667–11, 15, 19–20
   label-change.ts9.37009.676–57
   pricing-label.ts7.21008.2312–167
   sync-labels-to-config.ts14.280016.669–33
src/shared21.377.692525 
   issue.ts77.2754.5410089.4721, 51
   label.ts15.380016.669–22, 26–28, 37–56, 62–75, 80–93
   permissions.ts11.620012.198–62
   pricing.ts7.310010.715–7, 11–29, 33–41
src/types87.5505087.5 
   env.ts100100100100 
   github.ts100100100100 
   plugin-input.ts100100100100 
   typeguards.ts66.66033.3366.6615, 24

src/shared/pricing.ts Outdated Show resolved Hide resolved
src/worker.ts Outdated Show resolved Hide resolved
tests/__mocks__/handlers.ts Outdated Show resolved Hide resolved
@gentlementlegen
Copy link
Member Author

@0x4007 Required changes are within #11

@0x4007
Copy link
Member

0x4007 commented Jun 24, 2024

@0x4007 Required changes are within #11

Why didn't you include them in the same pull? I could have just viewed the diff from my last review to easily confirm that everything was addressed here.

Also knip looks broken now.

@gentlementlegen
Copy link
Member Author

@0x4007 I cannot edit this PR as it is within this repo (not from a fork where I have permissions) so I have to add another PR (or edit with VSCode within the browser like we tried yesterday).
The broken Knip is with pull_request_target which should not exist, and shall stop running in favor of pull_request one which is green.

chore: pinned node version for worker-deploy.yml
@0x4007
Copy link
Member

0x4007 commented Jul 2, 2024

@0x4007 I cannot edit this PR as it is within this repo

None of these observations make sense (in reference to you not being able to edit my pull the other day.) You opened this pull so regardless of where the branch is located you have write permissions. You're not doing something right.

@gentlementlegen
Copy link
Member Author

@0x4007 Could be because I always use https login and not tokens, or because I login through Jetbrains OAuth probably, I will figure this out. In the meantime, changes have been merged here, so lemme know if this can be merged too.

src/worker.ts Outdated Show resolved Hide resolved
src/worker.ts Outdated Show resolved Hide resolved
src/worker.ts Show resolved Hide resolved
@0x4007
Copy link
Member

0x4007 commented Jul 4, 2024

After you address my review I think you should just merge.

@gentlementlegen
Copy link
Member Author

gentlementlegen commented Jul 4, 2024

@0x4007 I will replace messages and fix error codes to be 4XX as per the HTTP RFC. 5XX should never occur except on crash on unhandled errors by the server (aka the Action).

A great description on how to chose error codes: https://stackoverflow.com/a/39639949/10346405

@gentlementlegen gentlementlegen merged commit 4bf1916 into main Jul 4, 2024
5 of 9 checks passed
gentlementlegen added a commit to gentlementlegen/daemon-pricing that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants