Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests #5

Closed
Keyrxng opened this issue Jun 22, 2024 · 5 comments · Fixed by #6
Closed

Add unit tests #5

Keyrxng opened this issue Jun 22, 2024 · 5 comments · Fixed by #6

Comments

@Keyrxng
Copy link
Member

Keyrxng commented Jun 22, 2024

Add some unit tests to the project

time: < 1 hour

original context #4 (comment)

@0x4007 0x4007 added good first issue Good for newcomers Time: <1 Hour and removed good first issue Good for newcomers labels Jun 24, 2024
Copy link

ubiquibot bot commented Jun 24, 2024

! action has an uncaught error

Copy link

ubiquibot bot commented Jun 24, 2024

! action has an uncaught error

Copy link

ubiquibot bot commented Jun 26, 2024

+ Evaluating results. Please wait...

Copy link

[ 50 WXDAI ]

@Keyrxng
Contributions Overview
View Contribution Count Reward
Issue Task 1 50
Conversation Incentives
Comment Formatting Relevance Reward

[ 0 WXDAI ]

@0x4007
Contributions Overview
View Contribution Count Reward
Review Comment 1 0
Conversation Incentives
Comment Formatting Relevance Reward
Looks fine. You can merge if @gentlementlegen doesn't get around…
1.3
content:
  p:
    count: 13
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -

[ 0.9 WXDAI ]

@gentlementlegen
Contributions Overview
View Contribution Count Reward
Review Comment 10 0.9
Conversation Incentives
Comment Formatting Relevance Reward
Has to be updated to avoid comment spam. Refer to https://github…
1.1
content:
  p:
    count: 11
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
See https://github.com/ubiquity/ts-template/blob/development/jes…
0.9
content:
  p:
    count: 9
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.5 0.45
Do we need the sha here?
0.6
content:
  p:
    count: 6
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.5 0.3
Remove comment probably
0.3
content:
  p:
    count: 3
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.1 0.03
Can this TODO be solved beforehand?
0.6
content:
  p:
    count: 6
    score: 1
wordValue: 0.1
formattingMultiplier: 1
0.2 0.12
Why all the comments?
0.4
content:
  p:
    count: 4
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
Why is this required? Also this file doesn't seem to be properly…
1.3
content:
  p:
    count: 13
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
I am not sure about the proper course to chose as we do not use …
4.6
content:
  p:
    count: 45
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
I was referring to the eslint rule disable? Does this regex caus…
1.4
content:
  p:
    count: 14
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -
This package has been deprecated, if you can please update it to…
1.4
content:
  p:
    count: 13
    score: 1
  code:
    count: 1
    score: 1
wordValue: 0.1
formattingMultiplier: 1
- -

Copy link

ubiquibot bot commented Jun 26, 2024

[ 101.6 WXDAI ]

@Keyrxng
Contributions Overview
ViewContributionCountReward
IssueSpecification13
IssueTask150
ReviewComment232.4
ReviewComment216.2
Conversation Incentives
CommentFormattingRelevanceReward
Add some unit tests to the project
time: < 1 hour

...

3

h5:
  count: 1
  score: "1"
  words: 4
13
@gentlementlegen added some tests covering things. I've also dec...
18.2
code:
  count: 2
  score: "4"
  words: 3
0.7318.2
@gentlementlegen I've cleaned things up, bumped ts and the plugi...
14.20.6914.2
@gentlementlegen added some tests covering things. I've also dec...
9.1
code:
  count: 2
  score: "2"
  words: 3
0.739.1
@gentlementlegen I've cleaned things up, bumped ts and the plugi...
7.10.697.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants