Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(development): release 1.3.1 #23

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 18, 2024

🤖 I have created a release beep boop

1.3.1 (2024-06-19)

⚠ BREAKING CHANGES

  • bundle splitting (#13)

Features

Bug Fixes

  • fixed compilation and erc20 tests (63c3823)
  • fixed erc721 tests and errors (414f29f)
  • this makes no sense (881f006)

This PR was generated with Release Please. See documentation.

@github-actions github-actions bot force-pushed the release-please--branches--development--components--permit-generation branch from 85e5168 to a43f502 Compare June 19, 2024 07:44
@rndquu
Copy link
Contributor

rndquu commented Jun 19, 2024

@gentlementlegen What is the expected flow of the release-please workflow?

  1. development is merged into main manually
  2. release-please bumps the version and creates a PR with updated version to the development branch
  3. development is merged into main manually again with bumped version

This one?

@gentlementlegen
Copy link
Member

@rndquu Correct. I think it's doing weird things because beforehand the package was published manually through the npm CLI, and not through the Action, and because release-please does not find any tags and releases it considers this to be the first one (so 1.0.0). Maybe pushing manually a 1.3.0 tag can fix it.

@0x4007
Copy link
Member

0x4007 commented Jun 19, 2024

What is the purpose of these releases? npm publishing?

@gentlementlegen
Copy link
Member

@0x4007 Creates a release and a tag, plus a changelog, which is useful for the NPM releases to have the proper versions.

@0x4007
Copy link
Member

0x4007 commented Jun 19, 2024

It isn't clear to me how I can unsubscribe from these notifications.

@gentlementlegen gentlementlegen changed the title chore(development): release 1.0.0 chore(development): release 1.3.1 Jun 20, 2024
Copy link
Contributor Author

github-actions bot commented Jun 20, 2024

Lines Statements Branches Functions
Coverage: 63%
63.88% (237/371) 50% (34/68) 45% (18/40)

JUnit

Tests Skipped Failures Errors Time
15 0 💤 0 ❌ 0 🔥 14.2s ⏱️
Coverage Report (63%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files63.88504563.88 
src32.550032.55 
   generate-permits-from-context.ts25.640025.6417–96
   index.ts100100100100 
src/adapters80100080 
   index.ts801000809
src/adapters/supabase/helpers14.580014.58 
   supabase.ts33.33100033.3310–11
   user.ts14.810014.818–50
   wallet.ts11.110011.118–37
src/handlers73.5458.827573.54 
   encode-decode.ts95801009558
   generate-erc20-permit.ts66.1741.665066.1729–34, 41, 50–53, 58, 80–82, 88–90, 98–100, 128–130
   generate-erc721-permit.ts76.05508076.0560–68, 81, 87, 101–102, 116–117, 152–153
   generate-payout-permit.ts73.3333.3310073.3325–29
   index.ts100100100100 
   register-wallet.ts68.8861.535068.8815–21, 43, 52, 61–64, 77–78
src/types100100100100 
   env.ts100100100100 
   index.ts100100100100 
   permits.ts100100100100 
   plugin-input.ts100100100100 
   typeguards.ts100100100100 
src/utils87.55010087.5 
   keys.ts84.6133.3310084.6113–14, 18–19
   payoutConfigByNetworkId.ts100100100100 
tests100100100100 
   constants.ts100100100100 

@rndquu rndquu merged commit 37e28cc into development Jun 25, 2024
4 checks passed
@rndquu rndquu deleted the release-please--branches--development--components--permit-generation branch June 25, 2024 06:54
@rndquu rndquu mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants