Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: release-please-action downgrades version #28

Closed
rndquu opened this issue Jun 25, 2024 · 10 comments · Fixed by #34
Closed

CI: release-please-action downgrades version #28

rndquu opened this issue Jun 25, 2024 · 10 comments · Fixed by #34

Comments

@rndquu
Copy link
Member

rndquu commented Jun 25, 2024

Check this PR which was created automatically by this workflow.

Initially that PR downgraded the package version to 1.0.0 although the expected behavior was to bump the version.

What should be done:

  • find out and fix the root cause why google-github-actions/release-please-action downgrades the version instead of bumping it
  • make sure that on every new commit with message pattern feat: * a new PR is created with a bumped version

P.S. Expected release flow

@rndquu
Copy link
Member Author

rndquu commented Jun 25, 2024

@gentlementlegen Pls check the description

@gentlementlegen
Copy link
Member

My guess is that because the package was previously released manually, it doesn't match the version on the repo. Afaik release-please will look for the all the commit names, then check the current package version and the repo latest tag. And it seems there is currently no tag inside this repository which would bring it back to 1.0.0 (just a guess).
Also the package should be changed to https://github.com/googleapis/release-please since the previous one is now deprecated.

@gentlementlegen
Copy link
Member

/start

Copy link

ubiquibot bot commented Jul 8, 2024

DeadlineMon, Jul 8, 5:51 AM UTC
Registered Wallet 0x0fC1b909ba9265A846b82CF4CE352fc3e7EeB2ED
Tips:
  • Use /wallet 0x0000...0000 if you want to update your registered payment wallet address.
  • Be sure to open a draft pull request as soon as possible to communicate updates on your progress.
  • Be sure to provide timely updates to us when requested, or you will be automatically unassigned from the task.

@gentlementlegen gentlementlegen linked a pull request Jul 8, 2024 that will close this issue
@gentlementlegen
Copy link
Member

@rndquu It seems the publishing failed somehow: https://github.com/ubiquibot/permit-generation/actions/runs/9854824504/job/27208423101#step:6:15 investigating

@gentlementlegen
Copy link
Member

@rndquu Re-ran publishing and everything went fine https://github.com/ubiquibot/permit-generation/actions/runs/9858376185
Latest npm: https://www.npmjs.com/package/@ubiquibot/permit-generation

@rndquu
Copy link
Member Author

rndquu commented Jul 10, 2024

@rndquu Re-ran publishing and everything went fine https://github.com/ubiquibot/permit-generation/actions/runs/9858376185 Latest npm: https://www.npmjs.com/package/@ubiquibot/permit-generation

So this issue should be closed as completed, right?

@gentlementlegen
Copy link
Member

@rndquu I believe the version should never be downgraded moving forward. Let's keep an eye on it and eventually re-open the ticket but we should be good to go!

@rndquu rndquu closed this as completed Jul 10, 2024
Copy link

ubiquibot bot commented Jul 10, 2024

+ Evaluating results. Please wait...

Copy link

ubiquibot bot commented Jul 10, 2024

[ 138.9 WXDAI ]

@gentlementlegen
Contributions Overview
ViewContributionCountReward
IssueTask150
IssueComment40
IssueComment418.5
ReviewComment635.2
ReviewComment635.2
Conversation Incentives
CommentFormattingRelevanceReward
My guess is that because the package was previously released man...
-
code:
  count: 2
  score: "0"
  words: 5
0.61-
@rndquu It seems the publishing failed somehow: https://github.c...
-0.66-
@rndquu Re-ran publishing and everything went fine https://githu...
-0.24-
@rndquu I believe the version should never be downgraded moving ...
-0.75-
My guess is that because the package was previously released man...
10.5
code:
  count: 2
  score: "2"
  words: 5
0.6110.5
@rndquu It seems the publishing failed somehow: https://github.c...
2.20.662.2
@rndquu Re-ran publishing and everything went fine https://githu...
2.70.242.7
@rndquu I believe the version should never be downgraded moving ...
3.10.753.1
@rndquu I added an empty commit that bumped the version to `...
7.2
a:
  count: 1
  score: "1"
  words: 1
code:
  count: 1
  score: "1"
  words: 3
0.827.2
@rndquu No need to merge `main` into `development ...
4.2
code:
  count: 3
  score: "3"
  words: 3
0.634.2
@rndquu We can merge it back, it is not really important as the ...
4.40.8054.4
The version should never be manually changed that's why I believ...
15.5
li:
  count: 3
  score: "3"
  words: 35
code:
  count: 5
  score: "5"
  words: 5
0.77515.5
Well ideally our main branch should be the release branch. But a...
2.40.82.4
Correct. Also note that the deployment of the package happens af...
1.50.8251.5
@rndquu I added an empty commit that bumped the version to `...
7.2
a:
  count: 1
  score: "1"
  words: 1
code:
  count: 1
  score: "1"
  words: 3
0.827.2
@rndquu No need to merge `main` into `development ...
4.2
code:
  count: 3
  score: "3"
  words: 3
0.634.2
@rndquu We can merge it back, it is not really important as the ...
4.40.8054.4
The version should never be manually changed that's why I believ...
15.5
li:
  count: 3
  score: "3"
  words: 35
code:
  count: 5
  score: "5"
  words: 5
0.77515.5
Well ideally our main branch should be the release branch. But a...
2.40.82.4
Correct. Also note that the deployment of the package happens af...
1.50.8251.5

[ 159 WXDAI ]

@rndquu
Contributions Overview
ViewContributionCountReward
IssueSpecification125
IssueComment22.8
ReviewComment5131.2
Conversation Incentives
CommentFormattingRelevanceReward
Check [this](https://github.com/ubiquibot/permit-generation/pull...
25
a:
  count: 5
  score: "5"
  words: 10
li:
  count: 2
  score: "2"
  words: 60
code:
  count: 2
  score: "2"
  words: 4
125
@gentlementlegen Pls check the description...
10.81
> @rndquu Re-ran publishing and everything went fine https://...
1.80.841.8
@gentlementlegen So we should: 1. Merge this PR into `main&...
13
li:
  count: 2
  score: "4"
  words: 16
code:
  count: 3
  score: "6"
  words: 3
0.5513
> @rndquu No need to merge `main` into `developme...
14.2
code:
  count: 5
  score: "10"
  words: 5
0.7414.2
> @rndquu We can merge it back, it is not really important as...
48
a:
  count: 1
  score: "2"
  words: 1
li:
  count: 3
  score: "6"
  words: 43
code:
  count: 8
  score: "16"
  words: 17
0.8348
> The version should never be manually changed that's why I b...
24.8
li:
  count: 3
  score: "6"
  words: 35
code:
  count: 8
  score: "16"
  words: 9
0.6924.8
> Well ideally our main branch should be the release branch. ...
31.2
li:
  count: 4
  score: "8"
  words: 56
code:
  count: 7
  score: "14"
  words: 9
0.831.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants