Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(main): release 1.4.0 #34

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 8, 2024

πŸ€– I have created a release beep boop

1.4.0 (2024-07-08)

⚠ BREAKING CHANGES

  • bundle splitting (#13)

Features

Bug Fixes

  • fixed compilation and erc20 tests (63c3823)
  • fixed erc721 tests and errors (414f29f)
  • tests mock handler usage (91470cc)
  • this makes no sense (881f006)

Miscellaneous Chores


This PR was generated with Release Please. See documentation.

@gentlementlegen
Copy link
Member

@rndquu I added an empty commit that bumped the version to 1.4.0 here so going forward it should not downgrade the version anymore. I will also fix Knip and Jest tests since I notice they are not fixed like we did in other repos. Hopefully #28 should be fixed afterwards!

@gentlementlegen gentlementlegen linked an issue Jul 8, 2024 that may be closed by this pull request
@rndquu
Copy link
Contributor

rndquu commented Jul 8, 2024

@gentlementlegen So we should:

  1. Merge this PR into main
  2. Then merge main into development

Correct?

@gentlementlegen
Copy link
Member

@rndquu No need to merge main into development, just merging into main.

@rndquu
Copy link
Contributor

rndquu commented Jul 8, 2024

@rndquu No need to merge main into development, just merging into main.

But this way the main branch will have v1.4.0 while the development branch will still be v1.3.1

@gentlementlegen
Copy link
Member

@rndquu We can merge it back, it is not really important as the version is based on the conventional commit comments and not on the tags of the branch / repo nor the package version. But to keep it in sync we can do so.

@rndquu
Copy link
Contributor

rndquu commented Jul 8, 2024

@rndquu We can merge it back, it is not really important as the version is based on the conventional commit comments and not on the tags of the branch / repo nor the package version. But to keep it in sync we can do so.

It's important for a developer to keep versions in sync. When you git clone https://github.com/ubiquibot/permit-generation you get v1.3.1 from the development branch while the published one would be v1.4.0 so it's literally the 1st question "How to get the latest version?".

What is the expected flow of using release-please workflow, this one?

This PR introduces a different flow:

  1. A change is made in the development
  2. release-please bumps the version and creates a PR with updated version to the main branch
  3. We merge main into development to keep versions in sync

I'm trying to find out what approach we should use for all of the ubiquity repositories.

@gentlementlegen
Copy link
Member

The version should never be manually changed that's why I believed it wouldn't matter (rest of the code is in sync). The difference in version happens because we use development as the default and main as the production.

Current flow within this PR is:

  • a push is made to main
  • release please bumps the version, creates a changelog, which targets main
  • PR is merged, triggers publishing of the package from the main branch

@rndquu
Copy link
Contributor

rndquu commented Jul 9, 2024

The version should never be manually changed that's why I believed it wouldn't matter (rest of the code is in sync). The difference in version happens because we use development as the default and main as the production.

Current flow within this PR is:

  • a push is made to main
  • release please bumps the version, creates a changelog, which targets main
  • PR is merged, triggers publishing of the package from the main branch

How does the development branch sync the package.json version from the main branch?

@gentlementlegen
Copy link
Member

Well ideally our main branch should be the release branch. But as you said, let's merge back main into develop in the meantime!

@rndquu
Copy link
Contributor

rndquu commented Jul 9, 2024

Well ideally our main branch should be the release branch. But as you said, let's merge back main into develop in the meantime!

So the flow is:

  1. Changes are made in the development branch
  2. We manually merge development into main
  3. release-please bumps the version and creates a PR with updated version to the main branch
  4. We manually merge main into development to keep package.json version in sync

@gentlementlegen
Copy link
Member

Correct. Also note that the deployment of the package happens after step 3 is completed.

@gentlementlegen gentlementlegen merged commit 76287e6 into main Jul 9, 2024
@gentlementlegen gentlementlegen deleted the release-please--branches--main--components--permit-generation branch July 9, 2024 09:50
Copy link
Contributor Author

github-actions bot commented Jul 9, 2024

πŸ€– Created releases:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: release-please-action downgrades version
2 participants