-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: permits are generated from the calculation results and redirect to the permit claim page #8
feat: permits are generated from the calculation results and redirect to the permit claim page #8
Conversation
Changes in this PR: The module is now capable of generating permits for the user rewards. It creates the permit and links it inside each user reward information. Last successful run: https://github.com/gentlementlegen/conversation-rewards/actions/runs/8642076491/job/23692567706#step:3:85 You can click on the links to open the reward page. Later on I believe we want this logic to be moved to the kernel. As they don't communicate yet I thought it'd better to have a first version that is fully autonomous. Also it currently has a 5 digits precision for rewards, which is maybe not wanted. Let me know if you wanna round number to fewer digits. Required environment variables to run properly:
And Knip failing as usual for the same reasons 🤡 and Jest because env variables are not set yet. |
Good catch! I will fix this repository Knip asap, also review the pr today. |
Knip config fixed at #11 I am reviewing this pull request now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a few comments to clarify, but overall the pull request is very useful. Good job! I think it would be useful to add documentation about releases, perhaps an automated label in README.md
would be fine and add the documentation on generating rewards on different network ids.
Why five digits of precision? The industry standard is 18. |
looks like 2 npm packages are in conflict @gentlementlegen |
I am using 18 digits, I meant that the final result can potentially be 4.1654627 WXDAI for example, and I don't recall having such results with the version we have currently for calculating the total. |
# Conflicts: # .github/workflows/main.yml # action.yml # package.json # src/parser/permit-generation-module.ts # src/types/env.d.ts # yarn.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good
dd6b3ee
into
ubiquity-os-marketplace:development
I noticed now that Might wanna consider have it rolling on |
You can add words to cspell config. Sure you should run on pulls. |
Resolves #9
Depends on ubiquity-os/permit-generation#10