Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: github comment generation and posting #12

Merged
merged 27 commits into from
Apr 25, 2024
Merged

feat: github comment generation and posting #12

merged 27 commits into from
Apr 25, 2024

Conversation

gentlementlegen
Copy link
Member

@gentlementlegen gentlementlegen commented Apr 15, 2024 •
edited
Loading

Resolves #5

Depends on #8

Reviews looks gigantic but it's only due to the API snapshots I promise.

@gentlementlegen
Copy link
Member Author

Example of successful comment posting with results:
https://github.com/Meniole/test/issues/1#issuecomment-2056572986

@gentlementlegen gentlementlegen mentioned this pull request Apr 15, 2024
Merged
@ubiquibot ubiquibot bot closed this Apr 17, 2024
@0x4007 0x4007 reopened this Apr 17, 2024
0x4007
0x4007 reviewed Apr 18, 2024
View reviewed changes
Copy link
Member

@0x4007 0x4007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code quality per usual

rewards-configuration.default.yml Outdated Show resolved Hide resolved
src/parser/github-comment-module.ts Outdated Show resolved Hide resolved
src/types/payout.ts Outdated Show resolved Hide resolved
@gentlementlegen
Copy link
Member Author

@0x4007 I believe that if I had all the tests in this PR it will become enormous, maybe I ought to do it in a separate PR.

@gentlementlegen gentlementlegen marked this pull request as ready for review April 18, 2024 08:45
0x4007
0x4007 reviewed Apr 18, 2024
View reviewed changes
rewards-configuration.default.yml Show resolved Hide resolved
src/issue-activity.ts Show resolved Hide resolved
src/issue-activity.ts Show resolved Hide resolved
src/parser/github-comment-module.ts Outdated Show resolved Hide resolved
@0x4007
Copy link
Member

0x4007 commented Apr 18, 2024

@0x4007 I believe that if I had all the tests in this PR it will become enormous, maybe I ought to do it in a separate PR.

I think it's fine. I generally scrutinize test code less than normal program code anyways.

0x4007
0x4007 reviewed Apr 21, 2024
View reviewed changes
src/types/payout.ts Outdated Show resolved Hide resolved
@gentlementlegen gentlementlegen mentioned this pull request Apr 21, 2024
Merged
whilefoo
whilefoo suggested changes Apr 22, 2024
View reviewed changes
src/parser/github-comment-module.ts Outdated Show resolved Hide resolved
tests/process.issue.test.ts Show resolved Hide resolved
src/parser/github-comment-module.ts Outdated Show resolved Hide resolved
src/parser/github-comment-module.ts Outdated Show resolved Hide resolved
src/issue-activity.ts Show resolved Hide resolved
src/parser/github-comment-module.ts Show resolved Hide resolved
@gentlementlegen gentlementlegen merged commit a466667 into ubiquity-os-marketplace:development Apr 25, 2024
2 of 3 checks passed
@gentlementlegen gentlementlegen deleted the feat/github-comment branch April 25, 2024 14:29
@ubiquibot ubiquibot bot mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whilefoo whilefoo whilefoo approved these changes

@gitcoindev gitcoindev Awaiting requested review from gitcoindev

@0x4007 0x4007 Awaiting requested review from 0x4007

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Post comment with summary and details to GitHub issue
3 participants
@gentlementlegen @0x4007 @whilefoo