chore: correct Knip configuration for conversation-rewards #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA: https://github.com/gitcoindev/conversation-rewards/actions/runs/8643695354/job/23697259210 and this pull request. I fixed the workflow, dependencies and configuration issues. Knip is failing with a few real findings that should be addressed in other pull requests. |
|
@gitcoindev Thanks for your help. Maybe Knip errors can be fixed through #8 directly. Could you also fix Jest at the same? It seems that |
|
@gentlementlegen I upgraded Knip to latest version, fixed all Knip warnings and Jest. |
molecula451
approved these changes
Apr 11, 2024
molecula451
merged commit 536a637
into
ubiquity-os-marketplace:development
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10