feat: tests for modules #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x4007
reviewed
Apr 22, 2024
0x4007
reviewed
Apr 22, 2024
|
Apologies for the PR spam. This aims to cover as much as possible with tests. It also solves many bugs encountered while testing, such as ignoring or including comments from pull requests that were not related, or on the contrary to ignore comments that should be part of the final result. All the API is mocked, because if anyone would happen to add or delete a comment it would break all the tests. It also allows for fine grained testing for edge cases. PR looks big again, but mostly contains mocked API results. Last run: https://github.com/Meniole/test/issues/1#issuecomment-2077704327 |
whilefoo
suggested changes
Apr 28, 2024
whilefoo
suggested changes
May 3, 2024
whilefoo
approved these changes
May 5, 2024
gentlementlegen
merged commit a43b17d
into
ubiquity-os-marketplace:development
2 of 3 checks passed
This was referenced Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #12