-
Notifications
You must be signed in to change notification settings - Fork 21
Update dependencies for 3.1.0 #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Review ChecklistDo not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed. Trivial Change
Code
Architecture
|
@@ -54,7 +54,7 @@ prost-build = "^0.13" | |||
pwhash = "1.0.0" | |||
rand = "0.8.5" | |||
regex = "1.6.0" | |||
rocksdb = { version = "0.22.0", features = ["lz4"], default_features = false } | |||
rocksdb = { version = "0.23.0", features = ["lz4", "bindgen-runtime"], default_features = false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rocksdb 0.23.0 introduced bindgen-runtime
and bindgen-static
. bindgen-runtime
used to be the only and the default option, and bindgen-static
did not exist. Now, by using default_features
, we turn off bindgen-runtime
, and we don't have bindgen
at all... Weird. So we turn on this feature explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not necessary to update it now, but since we discovered and solved this upgrade issue, I think it's valuable to grab it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree
@@ -16,6 +16,7 @@ alcoholic_jwt = "4091.0.0" | |||
async-stripe = { version = "0.39.1", features = ["runtime-tokio-hyper"] } | |||
async-trait = "0.1.59" | |||
axum = { version = "0.5.15", features = ["ws"] } | |||
cc = "=1.2.15" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We pin the cc
version. [email protected]
(which is updated implicitly by a single deps update run) changes something so librocksdb_sys starts having issues with build through Bazel, throwing C++-related errors (probably due to incorrectly used C++17). It was discussed in Discord: https://discord.com/channels/665254494820368395/672580553677078548/1346804418489618443
We do suspect that something got broken in rust-lang/cc-rs#1403, but it does not affect cargo build
. Since we don't see a problem in pinning the version of the crate (discussed in the same Discord channel), we decided to do so in the end.
Usage and product changes
Update dependencies prior to release 3.1.0. In details:
rocksdb
cratecc
create to avoid breakingrocksdb
Bazel build.Motivation
Make sure that the dependencies are in a stable and non-conflicting state
Implementation
See comments.