Skip to content

Update dependencies to avoid conflicts with the server #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 5, 2025
Merged

Update dependencies to avoid conflicts with the server #396

merged 5 commits into from
Mar 5, 2025

Conversation

farost
Copy link
Member

@farost farost commented Mar 5, 2025

Usage and product changes

Update dependencies and the generated Cargo files for the newest version of the target repo.

Implementation

@farost farost added priority: high dependencies Pull requests that update a dependency file labels Mar 5, 2025
@farost farost requested a review from haikalpribadi as a code owner March 5, 2025 12:43
@typedb-bot
Copy link
Member

typedb-bot commented Mar 5, 2025 •
edited by flyingsilverfin
Loading

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.

Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

farost
farost commented Mar 5, 2025
View reviewed changes
dependencies/typedb/repositories.bzl Outdated
remote = "https://github.com/typedb/typedb-dependencies",
commit = "b4238789491bc0976407fe78a17d0a906f69c186", # sync-marker: do not remove this comment, this is used for sync-dependencies by @typedb_dependencies
remote = "https://github.com/farost/dependencies",
commit = "76245eebd5c2ce4ec73b0e2bf70b812809255077", # sync-marker: do not remove this comment, this is used for sync-dependencies by @typedb_dependencies
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typedb/typedb-dependencies#570

@farost farost mentioned this pull request Mar 5, 2025
Merged
@farost farost merged commit d1ef678 into typedb:3.0 Mar 5, 2025
1 of 4 checks passed
@farost farost deleted the update-deps-3.1 branch March 5, 2025 16:40
farost added a commit to typedb/typedb-driver that referenced this pull request Mar 5, 2025
@farost
Update dependencies for the 3.0.1 release (#742)
ffd8687 
## Usage and product changes
Update dependencies.

## Implementation
Similarly to typedb/typeql#396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flyingsilverfin flyingsilverfin flyingsilverfin approved these changes

@dmitrii-ubskii dmitrii-ubskii Awaiting requested review from dmitrii-ubskii

@haikalpribadi haikalpribadi Awaiting requested review from haikalpribadi

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farost @typedb-bot @flyingsilverfin