Skip to content

Update dependencies after axum reintroduction #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

farost
Copy link
Member

@farost farost commented Mar 4, 2025

Usage and product changes

Update dependencies and the generated Cargo files for the newest version of the target repo.

Implementation

@typedb-bot
Copy link
Member

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@farost farost marked this pull request as ready for review March 5, 2025 12:23
@farost farost requested a review from haikalpribadi as a code owner March 5, 2025 12:23
@farost farost added priority: high dependencies Pull requests that update a dependency file labels Mar 5, 2025
@farost farost marked this pull request as draft March 5, 2025 12:42
@farost farost changed the title Update dependencies to avoid conflicts with the server Update dependencies after axum reintroduction Mar 5, 2025
@flyingsilverfin flyingsilverfin deleted the branch typedb:3.0 March 25, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants