Use current time when overwriting model configuration. #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabrizian
requested review from
kthui and
Tabrizian
and removed request for
Tabrizian
GuanLuo
previously approved these changes
Jan 5, 2024
This change changes the way `model_repository_manager` tracks when a model's configuration was last updated. Instead of setting the tracked mtime to zero, the current system time is used. This means that in order to reload the local configuration file, a user will need to "touch" the config.pbtxt file such that its mtime is greater than the mtime recorded when overwriting the model's configuration values and then reload the model. Test coverage will be added in the next commit.
whoisj
force-pushed
the
jwyman/ensemble-config-mtime
branch
from
1a92a3a to
49bdf3e
Compare
GuanLuo
approved these changes
Jan 17, 2024
whoisj
added a commit
that referenced
this pull request
Jan 17, 2024
This change changes the way `model_repository_manager` tracks when a model's configuration was last updated. Instead of setting the tracked mtime to zero, the current system time is used. This means that in order to reload the local configuration file, a user will need to "touch" the config.pbtxt file such that its mtime is greater than the mtime recorded when overwriting the model's configuration values and then reload the model. Test coverage will be added in the next commit.
mc-nv
pushed a commit
that referenced
this pull request
Jan 17, 2024
This change changes the way `model_repository_manager` tracks when a model's configuration was last updated. Instead of setting the tracked mtime to zero, the current system time is used. This means that in order to reload the local configuration file, a user will need to "touch" the config.pbtxt file such that its mtime is greater than the mtime recorded when overwriting the model's configuration values and then reload the model. Test coverage will be added in the next commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change changes the way
model_repository_managertracks when a model's configuration was last updated. Instead of setting the tracked mtime to zero, the current system time is used. This means that in order to reload the local configuration file, a user will need to "touch" the config.pbtxt file such that its mtime is greater than the mtime recorded when overwriting the model's configuration values and then reload the model.MR w/ test code