Use current time when overwriting model configuration. #6727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
GuanLuo
reviewed
Jan 5, 2024
qa/L0_lifecycle/lifecycle_test.py
Outdated
| @@ -3254,6 +3255,83 @@ def test_concurrent_model_instance_load_sanity(self): | |||
| ) | |||
| self.assertTrue(triton_client.is_server_ready()) | |||
|
|
|||
| def test_ensemble_config_overwite(self): | |||
There was a problem hiding this comment.
I don't see the test case is doing anything with ensemble, should probably change the name of the test case.
There was a problem hiding this comment.
👍 good call, updated.
whoisj
force-pushed
the
jwyman/ensemble-config-mtime
branch
from
e339e59 to
b82b401
Compare
GuanLuo
reviewed
Jan 8, 2024
qa/L0_lifecycle/lifecycle_test.py
Outdated
|
|
||
| # Touch the local config.pbtxt and reload the file to ensure the local config | ||
| # is preferred because it has a more recent mtime. | ||
| Path(model_name + "/config.pbtxt").touch() |
There was a problem hiding this comment.
probably better to use os.path.join to compose the file path
qa/L0_lifecycle/test.sh
Outdated
| fi | ||
|
|
||
| set +e | ||
| python $LC_TEST LifeCycleTest.test_ensemble_config_overwite >>$CLIENT_LOG 2>&1 |
There was a problem hiding this comment.
reflect the new test case name
qa/L0_lifecycle/test.sh
Outdated
| @@ -1947,3 +1947,38 @@ else | |||
| fi | |||
|
|
|||
| exit $RET | |||
|
|
|||
| # LifeCycleTest.test_ensemble_config_overwite | |||
There was a problem hiding this comment.
reflect the new test case name
whoisj
force-pushed
the
jwyman/ensemble-config-mtime
branch
from
b82b401 to
94a7b7f
Compare
GuanLuo
previously approved these changes
Jan 10, 2024
whoisj
force-pushed
the
jwyman/ensemble-config-mtime
branch
3 times, most recently
from
601c3e5 to
31ebb73
Compare
|
@whoisj you might need to resolve conflicts on this branch. |
whoisj
force-pushed
the
jwyman/ensemble-config-mtime
branch
6 times, most recently
from
e668f6e to
919417e
Compare
This validates the change made to ../core wrt how model configuration mtime is handled.
whoisj
force-pushed
the
jwyman/ensemble-config-mtime
branch
from
919417e to
271848e
Compare
GuanLuo
approved these changes
Jan 17, 2024
whoisj
added a commit
that referenced
this pull request
Jan 17, 2024
This validates the change made to ../core wrt how model configuration mtime is handled.
mc-nv
pushed a commit
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This validates the change This validates the change made to
../corewrt how model configuration mtime is handled.MR to ../core