Fix loading of composing models for ensembles #810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
debermudez
reviewed
Jan 11, 2024
debermudez
approved these changes
Jan 11, 2024
tgerdesnv
added a commit
that referenced
this pull request
Jan 18, 2024
mc-nv
pushed a commit
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, there was no way for Model Analyzer to load ensemble composing models via the API. This meant that they all defaulted to auto-complete configs. Now (with a required change to Triton) they can be loaded and won't be overwritten when the main ensemble config is loaded.
Fixes #791
Needs this change to work: triton-inference-server/core#304