Add file/folder description (and other new features and bugfixes) #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 13d10be.
basename will strip the first character if it is accented. This commit add the mb_basename function, taken from https://bugs.php.net/bug.php?id=37268 This fixes: - file renaming on upload when a file with the same name already exists - comments and permissions ("éa.jpg" and "a.jpg" used the same file for comments/permissions) - photospheres folder ("éPhotoSpheres" was matching "PhotoSpheres") - file and folder name on the right menu - file and folder name in the rename textbox - filename in the left menu, the header and the RSS file - filename when downloading a picture or a zip The only remaining problem is with the exif infos on the right menu, but it is an external call to exif_read_data().
This add title for buttons on the ImageBar, RSS and right menubar.
The spinnger was generated on http://spiffygif.com/ with the following parameters: - 8 lines - corners 1.0 - trail 50 - rotate 0 - no shadow, halo - black foreground, white background - length 0 - width 10 - radius 18 Their license (at the bottom on the "Docs" tab) permits to use it on this project.
Some keys (left, right, up, space, escape) are always listened, making writing or moving inside the rename input or comment textarea difficult. This fixes thibaud-rohmer#248.
Before this commit, Menu::list_files() was returning only files considered to be an image or a video, even with $hidden set to true. Now we can get all the files a directory contains with a new option, in case some code expects the previous behaviour.
…erything* Now that Menu::list_files() is fixed, we can use it to effectively delete everything, e.g. a thumbnail folder containing xml metadatas among others files.
The return of self::Extension($file) was incorrectly checked, thus returning the 0 at the end of the function. This can cause problems, because `"foo" == 0` is true in PHP...
When a file or folder was renamed or deleted, its metadatas (tokens, xml and thumbnail) were kept. This commit will keep the Thumbs directory consistent with the picture directory.
There is now a new div (#image_panel_table) inside #image_panel, encompassing #bigimage and #image_bar. This change was made to have dynamic resizing inside #image_panel, which will help to display description (see next commit) with a variable height. It should not change the page rendering, with the exception of a picture displayed with a page height under 300px. Instead of reducing more and more #image_panel, now a scrollbar appears.
This new feature is optional (but activated by default). A new option added to the right menu permits to write a description, displayed between the image/video and the navigation buttons, or under the header for a folder. When a description is empty, it is hidden using CSS to remove its padding. The Description class is based on the Comments class.
When a comment or a description contained an ampersand, their saving was
throwing a warning:
"PHP Warning: SimpleXMLElement::addChild(): unterminated entity reference"
An XML with an empty content ("<content/>") was created.
This fixes this problem; a thorough explanation can be read here:
http://stackoverflow.com/a/555039
The change in Video.php to set a width was mandatory for 4:3 screens, otherwise the video stretched outside the screen.
|
Hello Thibaud, |
|
Hey Anarky, I haven't forgotten about your pull request, it's just that it's so big it I have no change requests so far, and I hope to be able to merge it soon ! Thanks ! On Fri, 31 Jul 2015 at 00:09 Anarky [email protected] wrote:
|
|
Hello Thibaud, If you are still planning to merge my changes, please tell me and I will resolve the conflicts. Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a pretty big PR; I made a summary of it, but every fix or new feature has its own commit.
Please tell me if you want me to split it in smaller PRs.
New features:
Fixes:
And some dead code removal.